Refactor feature extensions#3041
Merged
jbogard merged 3 commits intoLuckyPennySoftware:masterfrom Apr 23, 2019
lbargaoanu:feature_extensions
Merged
Refactor feature extensions#3041jbogard merged 3 commits intoLuckyPennySoftware:masterfrom lbargaoanu:feature_extensions
jbogard merged 3 commits intoLuckyPennySoftware:masterfrom
lbargaoanu:feature_extensions
Conversation
jbogard
approved these changes
Apr 22, 2019
Contributor
Author
|
Those derived classes seemed kind of anemic, so I went with extension methods. I don't use Asp Core much, so for me the name "feature" is kind of weird (extension sounds better), but I guess for most people it will sound familiar. |
lbargaoanu
changed the title
jbogard
approved these changes
Apr 23, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3039. I say, let's keep them, but whatever works.