undefined symbol Image::error while compiling with VS 2015 (win)

[timknip]

Building using mingw64 and VS 2015 borks here when using HAVE_RSVG. Image::error doesn't seem to be implemented. Strange thing is it compiles fine on Linux. Maybe a compiler thing?
Anyway: seems a good idea to implement Image::error.

Note: the combination mingw64 / VS 2015 works great, also with HAVE_RSVG.
Checked out some windows code here

[zbjornson]

You linked to a line with Canvas::Error -- is that what you meant?

[timknip]

@zbjornson Yes. error is declared in Image.h, but there's no implementation. Hence the undefined symbol.

[zbjornson]

Oh! I see it now :).

GCC might be treating that as the error function attribute, not sure.

[timknip]

@zbjornson Unrelated: a npm i on canvas@next (alpha.10 i think) borks with a 404 on a non-existing pre-built url (makes sense as there's no pre-built binaries for alpha.10. Would expect a fallback on build though. npm i doesn't get there.

D:\fp\tmp\tim>npm i canvas@next

> [email protected] install D:\fp\tmp\tim\node_modules\canvas
> node-pre-gyp install

node-pre-gyp ERR! install error
node-pre-gyp ERR! stack Error: 404 status code downloading tarball https://github.com/node-gfx/node-canvas-prebuilt/releases/download/v2.0.0-alpha.10/canvas-prebuilt-v2.0.0-alpha.
0-node-v57-win32-x64.tar.gz
node-pre-gyp ERR! stack     at Request.<anonymous> (D:\fp\tmp\tim\node_modules\node-pre-gyp\lib\install.js:118:27)
node-pre-gyp ERR! stack     at emitOne (events.js:121:20)
node-pre-gyp ERR! stack     at Request.emit (events.js:211:7)
node-pre-gyp ERR! stack     at Request.onRequestResponse (D:\fp\tmp\tim\node_modules\request\request.js:1074:10)
node-pre-gyp ERR! stack     at emitOne (events.js:116:13)
node-pre-gyp ERR! stack     at ClientRequest.emit (events.js:211:7)
node-pre-gyp ERR! stack     at HTTPParser.parserOnIncomingClient [as onIncoming] (_http_client.js:551:21)
node-pre-gyp ERR! stack     at HTTPParser.parserOnHeadersComplete (_http_common.js:117:23)
node-pre-gyp ERR! stack     at TLSSocket.socketOnData (_http_client.js:440:20)
node-pre-gyp ERR! stack     at emitOne (events.js:116:13)
node-pre-gyp ERR! System Windows_NT 6.3.9600
node-pre-gyp ERR! command "C:\\Program Files\\nodejs\\node.exe" "D:\\fp\\tmp\\tim\\node_modules\\node-pre-gyp\\bin\\node-pre-gyp" "install"
node-pre-gyp ERR! cwd D:\fp\tmp\tim\node_modules\canvas
node-pre-gyp ERR! node -v v8.9.1
node-pre-gyp ERR! node-pre-gyp -v v0.6.39
node-pre-gyp ERR! not ok
404 status code downloading tarball https://github.com/node-gfx/node-canvas-prebuilt/releases/download/v2.0.0-alpha.10/canvas-prebuilt-v2.0.0-alpha.10-node-v57-win32-x64.tar.gz
npm WARN [email protected] No description
npm WARN [email protected] No repository field.

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] install: `node-pre-gyp install`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\Tim\AppData\Roaming\npm-cache\_logs\2018-03-21T19_46_59_690Z-debug.log

[zbjornson]

@timknip I think that's #1111. 2.0.0-alpha.11 falls back to a build.

[Khorynthium]

I've got a fix for related #1205. But It was closed as a dup of this issue. So, here we go: #1206