Skip to content

Hard crash calling Context2d.prototype.filter #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tolmasky opened this issue Jun 21, 2015 · 0 comments
Closed

Hard crash calling Context2d.prototype.filter #568

tolmasky opened this issue Jun 21, 2015 · 0 comments

Comments

@tolmasky
Copy link

This line will crash node:

Context2d.prototype.filter

Perhaps worse, so do this:

Object.getOwnPropertyDescriptor(Context2d.prototype, "filter")

I think this is because GetFilter doesn't have a HasInstance guard. I think it should do something along the lines of

if (!HasInstace(this)) return default_value

(as opposed to throwing, since then getOwnPropertyDesctipor would throw. This would match Array.prototype.length for example which is 0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant