Acknowledgments do not seem to work on 1.0.3

[sbstp]

I've been trying to get acknowledgments working, but nothing seems to work.

// client.js
var socket = io('http://localhost:3000');

// the event is fired
socket.on('connect', function () {
  console.log('connected');
});

this.startSearch = function (what, callback) {
  socket.emit('start', {what: what}, function (data) {
    // this is never called
    console.log(data); 
  });
};

// server.js
// connected socket, start is fired, typeof callback is function
socket.on('start', function (what, callback) {
  var search = service.search(what);
  callback({id: search.id});
}

I've inspected the socket frames and I can see the data being sent. But the client callback is never called.

Both the client script and the node module are at version 1.0.3.

[jamesrom]

Further to this issue, it hangs the browser. The problem appears to be in the decodeString(str) function.

function decodeString(str) {
  var p = {};
  var i = 0;

  // look up type
  p.type = Number(str.charAt(0));
  if (null == exports.types[p.type]) return error();

  // look up attachments if type binary
  if (exports.BINARY_EVENT == p.type || exports.ACK == p.type) {
    p.attachments = '';
    while (str.charAt(++i) != '-') { // <-- problem here. non-terminating loop. str never contains '-'
      p.attachments += str.charAt(i);
    }
    p.attachments = Number(p.attachments);
  }
  ...

[Multiply]

We're having exactly this problem, across multiple browsers as well. They just hang.

I simply downgraded to 1.0.2

[ZloyDyadka]

+1

[rauchg]

Looking into this!

[JGAntunes]

Same issue here. Execution freezes in the while loop @jamesrom mentioned.

[sbstp]

I've just tried with 1.0.2 and the bug does not occur.

[kevin-roark]

hey all. I've looked into the issue a bit and it seems that the client build in 1.0.3 does not have the updated 2.2.0 socket.io-parser. this should be fixed very soon!

[alexiskattan]

@kevin-roark thanks you! Do you know when it will be fixed? Having the same issue here after going to 1.0.3. All the best!

[ashconnell]

Just letting yall know i have the same issue. Chrome on OSX hangs and requires a force quit if i use acknowledgements

[rauchg]

1.0.4 incoming with the fixed build!

[rauchg]

Also working on an enhanced release procedure to make sure this gets tested.

[ashconnell]

Perfect timing. I almost downgraded...

[JGAntunes]

@guille thanks! For when the release?

[rauchg]

Right about… now!

[sbstp]

Thanks a lot for the fast response & bug fix.

[ashconnell]

Yep that fixed it for me! Legend on the fast update

[JGAntunes]

Fixed it! Thanks a lot.

[rauchg]

Thanks @kevin-roark for the diagnosis!