FIX ignored options in converters configuration

Author: AymDev

CHANGELOG.md

@@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [1.1.1] - 2020-10-24
+### Fixed
+ - the converter `options` configuration key is not ignored anymore
+
 ## [1.1.0] - 2020-10-23
 ### Added
  - **Twig** `commonmark` filter
@@ -14,7 +18,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Added
  - Bundle base
 
-[Unreleased]: https://github.com/AymDev/CommonMarkBundle/compare/v1.1.0...HEAD
+[Unreleased]: https://github.com/AymDev/CommonMarkBundle/compare/v1.1.1...HEAD
+[1.1.1]: https://github.com/AymDev/CommonMarkBundle/compare/v1.1.0...v1.1.1
 [1.1.0]: https://github.com/AymDev/CommonMarkBundle/compare/v1.0.0...v1.1.0
 [1.0.0]: https://github.com/AymDev/CommonMarkBundle/releases/tag/v1.0.0
 

src/DependencyInjection/Configuration.php

@@ -21,7 +21,7 @@ public function getConfigTreeBuilder()
                                 ->values(['commonmark', 'github'])
                                 ->defaultValue('commonmark')
                             ->end()
-                            ->arrayNode('options')->ignoreExtraKeys()->end()
+                            ->variableNode('options')->end()
                             ->arrayNode('extensions')->scalarPrototype()->end()
                         ->end()
                     ->end()

tests/DependencyInjection/ConfigurationTest.php

@@ -2,7 +2,7 @@
 
 namespace Tests\AymDev\CommonMarkBundle\DependencyInjection;
 
-use Aymdev\CommonmarkBundle\DependencyInjection\AymdevCommonMarkExtension;
+use Aymdev\CommonmarkBundle\DependencyInjection\AymdevCommonmarkExtension;
 use Aymdev\CommonmarkBundle\DependencyInjection\Compiler\ConvertersPass;
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
@@ -17,7 +17,7 @@ class ConfigurationTest extends TestCase
     public function testConfigurationFormat($config)
     {
         $container = new ContainerBuilder();
-        $extension = new AymdevCommonMarkExtension();
+        $extension = new AymdevCommonmarkExtension();
 
         self::assertNull($extension->load($config, $container));
         $converters = $container->getParameter(ConvertersPass::PARAMETER_CONVERTERS);
@@ -44,4 +44,19 @@ public function provideConfiguration(): \Generator
             yield [Yaml::parse(file_get_contents($file))];
         }
     }
+
+    public function testConverterOptionsAreWellParsed()
+    {
+        $file = __DIR__ . '/../Fixtures/config/configuration_options.yaml';
+        $config = Yaml::parse(file_get_contents($file));
+
+        $container = new ContainerBuilder();
+        $extension = new AymdevCommonmarkExtension();
+
+        $extension->load($config, $container);
+        $converter = $container->getParameter(ConvertersPass::PARAMETER_CONVERTERS);
+
+        $expectedOptions = $config['aymdev_commonmark']['converters']['my_converter']['options'];
+        self::assertSame($expectedOptions, $converter['my_converter']['options']);
+    }
 }

tests/Fixtures/config/configuration_options.yaml

@@ -0,0 +1,10 @@
+aymdev_commonmark:
+    converters:
+        my_converter:
+            type: commonmark
+            options:
+                renderer:
+                    soft_break: "\n"
+                use_underscore: false
+            extensions:
+                - League\CommonMark\Extension\Autolink\AutolinkExtension