Skip to content

Commit 64f6dad

Browse files
ludamadjust-mitch
andauthored
chore(network_test.sh): work around 143 by disabling stern (#10436)
Likely will help with the random 143's we see --------- Co-authored-by: Mitch <[email protected]>
1 parent 9443e8e commit 64f6dad

File tree

2 files changed

+9
-7
lines changed

2 files changed

+9
-7
lines changed

yarn-project/end-to-end/scripts/network_test.sh

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -53,11 +53,13 @@ if [ "$FRESH_INSTALL" = "true" ]; then
5353
kubectl delete namespace "$NAMESPACE" --ignore-not-found=true --wait=true --now --timeout=10m
5454
fi
5555

56-
STERN_PID=""
56+
# STERN_PID=""
5757
function copy_stern_to_log() {
58-
ulimit -n 4096
59-
stern spartan -n $NAMESPACE > $SCRIPT_DIR/network-test.log &
60-
STERN_PID=$!
58+
# TODO(AD) we need to figure out a less resource intensive solution than stern
59+
# ulimit -n 4096
60+
# stern spartan -n $NAMESPACE > $SCRIPT_DIR/network-test.log &
61+
echo "disabled until less resource intensive solution than stern implemented" > $SCRIPT_DIR/network-test.log &
62+
# STERN_PID=$!
6163
}
6264

6365
function show_status_until_pxe_ready() {
@@ -113,7 +115,7 @@ show_status_until_pxe_ready &
113115

114116
function cleanup() {
115117
# kill everything in our process group except our process
116-
trap - SIGTERM && kill -9 $(pgrep -g $$ | grep -v $$) $(jobs -p) $STERN_PID &>/dev/null || true
118+
trap - SIGTERM && kill -9 $(pgrep -g $$ | grep -v $$) $(jobs -p) &>/dev/null || true
117119

118120
if [ "$CLEANUP_CLUSTER" = "true" ]; then
119121
kind delete cluster || true

yarn-project/end-to-end/src/spartan/gating-passive.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,8 @@ describe('a test that passively observes the network in the presence of network
4848

4949
const ETHEREUM_HOST = `http://127.0.0.1:${HOST_ETHEREUM_PORT}`;
5050
const PXE_URL = `http://127.0.0.1:${HOST_PXE_PORT}`;
51-
// 50% is the max that we expect to miss
52-
const MAX_MISSED_SLOT_PERCENT = 0.5;
51+
// 60% is the max that we expect to miss
52+
const MAX_MISSED_SLOT_PERCENT = 0.6;
5353

5454
afterAll(async () => {
5555
await runAlertCheck(config, qosAlerts, debugLogger);

0 commit comments

Comments
 (0)