Upgrade Resiliency: Adds Code to Enable Advanced Replica Selection Feature for Preview (#4180)

kundadebdatta · kirankumarkolli · commit 1a3a0d5c27de · 2023-11-15T10:58:30.000-08:00
* Code changes to enable replica validation for preview.

* Code changes to enable replica validation for preview and GA.
diff --git a/Microsoft.Azure.Cosmos/src/Util/ConfigurationManager.cs b/Microsoft.Azure.Cosmos/src/Util/ConfigurationManager.cs
@@ -44,8 +44,6 @@ public static T GetEnvironmentVariable<T>(string variable, T defaultValue)
         public static bool IsReplicaAddressValidationEnabled(
             ConnectionPolicy connectionPolicy)
         {
-            bool replicaValidationDefaultValue = false;
-
             if (connectionPolicy != null
                 && connectionPolicy.EnableAdvancedReplicaSelectionForTcp.HasValue)
             {
@@ -55,7 +53,7 @@ public static bool IsReplicaAddressValidationEnabled(
             return ConfigurationManager
                     .GetEnvironmentVariable(
                         variable: ConfigurationManager.ReplicaConnectivityValidationEnabled,
-                        defaultValue: replicaValidationDefaultValue);
+                        defaultValue: true);
         }
 
         /// <summary>

Original file line number	Diff line number	Diff line change
`@@ -44,8 +44,6 @@ public static T GetEnvironmentVariable<T>(string variable, T defaultValue)`
`44`	`44`	`public static bool IsReplicaAddressValidationEnabled(`
`45`	`45`	`ConnectionPolicy connectionPolicy)`
`46`	`46`	`{`
`47`		`- bool replicaValidationDefaultValue = false;`
`48`		`-`
`49`	`47`	`if (connectionPolicy != null`
`50`	`48`	`&& connectionPolicy.EnableAdvancedReplicaSelectionForTcp.HasValue)`
`51`	`49`	`{`
`@@ -55,7 +53,7 @@ public static bool IsReplicaAddressValidationEnabled(`
`55`	`53`	`return ConfigurationManager`
`56`	`54`	`.GetEnvironmentVariable(`
`57`	`55`	`variable: ConfigurationManager.ReplicaConnectivityValidationEnabled,`
`58`		`- defaultValue: replicaValidationDefaultValue);`
	`56`	`+ defaultValue: true);`
`59`	`57`	`}`
`60`	`58`
`61`	`59`	`/// <summary>`