Skip to content

Bump Cosmos SDK to 3.33.0 and remove PartitionKey.None workaround #1420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
liliankasem opened this issue Mar 15, 2023 · 0 comments
Closed

Bump Cosmos SDK to 3.33.0 and remove PartitionKey.None workaround #1420

liliankasem opened this issue Mar 15, 2023 · 0 comments
Assignees

Comments

@liliankasem
Copy link
Member

liliankasem commented Mar 15, 2023

Bump Cosmos SDK to 3.33.0 and remove PartitionKey.None workaround in the CosmosDBConverter.

// Workaround until bug in Cosmos SDK is fixed
// Currently pending release: https://github.com/Azure/azure-cosmos-dotnet-v3/commit/d6e04a92f8778565eb1d1452738d37c7faf3c47a
QueryRequestOptions queryRequestOptions = new();
if (partitionKey != PartitionKey.None)
{
    queryRequestOptions = new() { PartitionKey = partitionKey };
}

to

QueryRequestOptions queryRequestOptions = new() { PartitionKey = partitionKey };

This is the commit that we are waiting to be released in the Cosmos SDK:

Note to double check which version this release goes into

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant