Skip to content

Allow users to specify IncludeEmptyEntriesInMessagePayload capability #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kshyju opened this issue Oct 17, 2022 · 4 comments
Open

Comments

@kshyju
Copy link
Member

kshyju commented Oct 17, 2022

For trigger payloads of collection type(ex: event hub trigger payload with batched messages), host will skip empty entries by default. We recently made a host level change so that host will not skip empty entries if worker includes IncludeEmptyEntriesInMessagePayload capability when advertising the capability list to host. The dotnet worker was updated to send this capability if user opts in for that(In the next major version, we will enable it by default). node worker should consider making similar change.

@ejizba
Copy link
Contributor

ejizba commented Oct 31, 2022

@kshyju I took a look at Azure/azure-functions-dotnet-worker#1091, and I'm confused by workerOptions. Is that unique to .NET? Can you explain how it works?

Specifically, I'm confused how it would handle the placeholder specialization scenario where the worker gets an initRequest with a dummy app and later a functionEnvironmentReloadRequest with the real app. AFAIK the only time we can set worker capabilities is during worker init, right? So seems like for placeholders the user would have no way to set these options

@ejizba
Copy link
Contributor

ejizba commented Oct 31, 2022

Discussed with @kshyju offline and filed Azure/azure-functions-host#8877 which would be a prereq for us doing this

@ejizba ejizba modified the milestones: Backlog Candidates, Tracking Oct 31, 2022
@ejizba ejizba changed the title Send IncludeEmptyEntriesInMessagePayload capability to host to get empty entries in payload Allow users to specify IncludeEmptyEntriesInMessagePayload capability May 24, 2023
@ejizba
Copy link
Contributor

ejizba commented May 24, 2023

The prereq in the host was fixed: Azure/azure-functions-host#8983. So we could theoretically support a flag now to let users specify this option

@ejizba ejizba modified the milestones: Tracking, Backlog Candidates May 24, 2023
@ejizba ejizba transferred this issue from Azure/azure-functions-nodejs-worker Oct 18, 2023
@ejizba
Copy link
Contributor

ejizba commented Oct 18, 2023

The worker PR to allow updating capabilities is here: Azure/azure-functions-nodejs-worker#720

Once that is merged, the library would actually be able to expose this particular capability to users if we want to, so moving the issue to the library repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants