add TimeSpanObjectTypeVisitor #524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
justinyoo
suggested changes
Dec 21, 2022
There was a problem hiding this comment.
@sinantutan Thanks for your PR! I left a comment. In addition to that, would you be able to add tests for your changes, please?
src/Microsoft.Azure.WebJobs.Extensions.OpenApi.Core/Visitors/TimeSpanObjectTypeVisitor.cs
Show resolved
Hide resolved
…eSpanObjectTypeVisitor
@justinyoo many thanks for reviewing my PR. I've made the changes you requested. Please let me know if anything is missing. |
justinyoo
approved these changes
Dec 23, 2022
Derich367
pushed a commit
to Derich367/azure-functions-openapi-extension
that referenced
this pull request
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #401 the type of TimeSpan is incorrectly displayed as a complex object. This PR aims for fixing this issue.
We can then have a new property in our Order class of the type TimeSpan
And achieve the following result
