You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The code is a little wierd for seeking past 2GB.
In partcular Posix has fseeko with the apparent intent that o==off_t==long long.
And of course Microsoft has _fseeki64.
My point is, I think we can safely deal with 64bit file offsets, without looping 32bits at a time.
As well, we should consider, maybe, dropping 32bit support?
i.e. long is 64bits on Unix64.
I understand we need some autoconfery. That if _MSC_VER doesn't mean targeting Microsoft runtime.
Maybe there is something we can/should to detect though, i.e. something its headers defines.
#if _WIN32 could imply the Windows runtime perhaps.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
-
The code is a little wierd for seeking past 2GB.
In partcular Posix has fseeko with the apparent intent that o==off_t==long long.
And of course Microsoft has _fseeki64.
My point is, I think we can safely deal with 64bit file offsets, without looping 32bits at a time.
As well, we should consider, maybe, dropping 32bit support?
i.e. long is 64bits on Unix64.
I understand we need some autoconfery. That if _MSC_VER doesn't mean targeting Microsoft runtime.
Maybe there is something we can/should to detect though, i.e. something its headers defines.
#if _WIN32 could imply the Windows runtime perhaps.
Beta Was this translation helpful? Give feedback.
All reactions