Fix circular dependency in Angular (#7714)

Fixes circular import introduced in msal-angular v4.0.9 and enables lint
rule to catch this in the future

Author: tnorling

change/@azure-msal-angular-34f593f3-625c-453f-bd2b-4793cf05757f.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "Fix circular dependency",
+  "packageName": "@azure/msal-angular",
+  "email": "[email protected]",
+  "dependentChangeType": "patch"
+}

change/@azure-msal-browser-3ef5a999-873c-4c3c-adac-ece031405cc6.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "Fix circular type imports",
+  "packageName": "@azure/msal-browser",
+  "email": "[email protected]",
+  "dependentChangeType": "patch"
+}

change/@azure-msal-common-589fd386-e7e6-432e-8aee-2bf17430df4c.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "Fix circular type imports",
+  "packageName": "@azure/msal-common",
+  "email": "[email protected]",
+  "dependentChangeType": "patch"
+}

change/@azure-msal-node-50ccabcc-b72f-496a-bc19-28502ee3dbf3.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "Fix circular type imports",
+  "packageName": "@azure/msal-node",
+  "email": "[email protected]",
+  "dependentChangeType": "patch"
+}

lib/msal-angular/src/msal.broadcast.service.ts

@@ -11,9 +11,9 @@ import {
   InteractionStatus,
 } from "@azure/msal-browser";
 import { BehaviorSubject, Observable, ReplaySubject, Subject } from "rxjs";
-import { MsalService } from "./msal.service";
 import { MsalBroadcastConfiguration } from "./msal.broadcast.config";
 import { MSAL_BROADCAST_CONFIG, MSAL_INSTANCE } from "./constants";
+import { name, version } from "./packageMetadata";
 
 @Injectable()
 export class MsalBroadcastService {
@@ -24,7 +24,6 @@ export class MsalBroadcastService {
 
   constructor(
     @Inject(MSAL_INSTANCE) private msalInstance: IPublicClientApplication,
-    private authService: MsalService,
     @Optional()
     @Inject(MSAL_BROADCAST_CONFIG)
     private msalBroadcastConfig?: MsalBroadcastConfiguration
@@ -34,8 +33,9 @@ export class MsalBroadcastService {
       this.msalBroadcastConfig &&
       this.msalBroadcastConfig.eventsToReplay > 0
     ) {
-      this.authService
+      this.msalInstance
         .getLogger()
+        .clone(name, version)
         .verbose(
           `BroadcastService - eventsToReplay set on BroadcastConfig, replaying the last ${this.msalBroadcastConfig.eventsToReplay} events`
         );
@@ -62,8 +62,9 @@ export class MsalBroadcastService {
         this._inProgress.value
       );
       if (status !== null) {
-        this.authService
+        this.msalInstance
           .getLogger()
+          .clone(name, version)
           .verbose(
             `BroadcastService - ${message.eventType} results in setting inProgress from ${this._inProgress.value} to ${status}`
           );

lib/msal-browser/src/cache/ITokenCache.ts

@@ -3,10 +3,10 @@
  * Licensed under the MIT License.
  */
 
-import { ExternalTokenResponse } from "@azure/msal-common/browser";
-import { SilentRequest } from "../request/SilentRequest.js";
-import { LoadTokenOptions } from "./TokenCache.js";
-import { AuthenticationResult } from "../response/AuthenticationResult.js";
+import type { ExternalTokenResponse } from "@azure/msal-common/browser";
+import type { SilentRequest } from "../request/SilentRequest.js";
+import type { LoadTokenOptions } from "./TokenCache.js";
+import type { AuthenticationResult } from "../response/AuthenticationResult.js";
 
 export interface ITokenCache {
     /**

lib/msal-browser/src/cache/TokenCache.ts

@@ -22,14 +22,14 @@ import {
     TimeUtils,
 } from "@azure/msal-common/browser";
 import { BrowserConfiguration } from "../config/Configuration.js";
-import { SilentRequest } from "../request/SilentRequest.js";
+import type { SilentRequest } from "../request/SilentRequest.js";
 import { BrowserCacheManager } from "./BrowserCacheManager.js";
-import { ITokenCache } from "./ITokenCache.js";
+import type { ITokenCache } from "./ITokenCache.js";
 import {
     createBrowserAuthError,
     BrowserAuthErrorCodes,
 } from "../error/BrowserAuthError.js";
-import { AuthenticationResult } from "../response/AuthenticationResult.js";
+import type { AuthenticationResult } from "../response/AuthenticationResult.js";
 import { base64Decode } from "../encode/Base64Decode.js";
 import * as BrowserCrypto from "../crypto/BrowserCrypto.js";
 

lib/msal-browser/src/utils/BrowserUtils.ts

@@ -14,7 +14,7 @@ import {
     BrowserConfigurationAuthErrorCodes,
     createBrowserConfigurationAuthError,
 } from "../error/BrowserConfigurationAuthError.js";
-import { BrowserConfiguration } from "../config/Configuration.js";
+import type { BrowserConfiguration } from "../config/Configuration.js";
 
 /**
  * Clears hash from window url.

lib/msal-common/src/authority/Authority.ts

@@ -51,7 +51,7 @@ import { CloudDiscoveryMetadata } from "./CloudDiscoveryMetadata.js";
 import { RegionDiscovery } from "./RegionDiscovery.js";
 import { RegionDiscoveryMetadata } from "./RegionDiscoveryMetadata.js";
 import { ImdsOptions } from "./ImdsOptions.js";
-import { AzureCloudOptions } from "../config/ClientConfiguration.js";
+import type { AzureCloudOptions } from "../config/ClientConfiguration.js";
 import { Logger } from "../logger/Logger.js";
 import { AuthError } from "../error/AuthError.js";
 import { IPerformanceClient } from "../telemetry/performance/IPerformanceClient.js";

lib/msal-common/src/cache/entities/AccountEntity.ts

@@ -4,7 +4,7 @@
  */
 
 import { CacheAccountType, Separators } from "../../utils/Constants.js";
-import { Authority } from "../../authority/Authority.js";
+import type { Authority } from "../../authority/Authority.js";
 import { ICrypto } from "../../crypto/ICrypto.js";
 import { ClientInfo, buildClientInfo } from "../../account/ClientInfo.js";
 import {

lib/msal-common/src/config/ClientConfiguration.ts

@@ -11,7 +11,7 @@ import {
     DEFAULT_TOKEN_RENEWAL_OFFSET_SEC,
 } from "../utils/Constants.js";
 import { version } from "../packageMetadata.js";
-import { Authority } from "../authority/Authority.js";
+import type { Authority } from "../authority/Authority.js";
 import { AzureCloudInstance } from "../authority/AuthorityOptions.js";
 import { CacheManager, DefaultStorageClass } from "../cache/CacheManager.js";
 import { ServerTelemetryManager } from "../telemetry/server/ServerTelemetryManager.js";

lib/msal-common/src/crypto/ICrypto.ts

@@ -7,8 +7,8 @@ import {
     ClientAuthErrorCodes,
     createClientAuthError,
 } from "../error/ClientAuthError.js";
-import { BaseAuthRequest } from "../request/BaseAuthRequest.js";
-import { ShrOptions, SignedHttpRequest } from "./SignedHttpRequest.js";
+import type { BaseAuthRequest } from "../request/BaseAuthRequest.js";
+import type { ShrOptions, SignedHttpRequest } from "./SignedHttpRequest.js";
 
 /**
  * The PkceCodes type describes the structure

lib/msal-common/src/logger/Logger.ts

@@ -3,7 +3,7 @@
  * Licensed under the MIT License.
  */
 
-import { LoggerOptions } from "../config/ClientConfiguration.js";
+import type { LoggerOptions } from "../config/ClientConfiguration.js";
 import { Constants } from "../utils/Constants.js";
 
 /**

lib/msal-common/src/request/BaseAuthRequest.ts

@@ -4,7 +4,7 @@
  */
 
 import { AuthenticationScheme } from "../utils/Constants.js";
-import { AzureCloudOptions } from "../config/ClientConfiguration.js";
+import type { AzureCloudOptions } from "../config/ClientConfiguration.js";
 import { StringDict } from "../utils/MsalTypes.js";
 import { StoreInCache } from "./StoreInCache.js";
 import { ShrOptions } from "../crypto/SignedHttpRequest.js";

lib/msal-node/src/config/ManagedIdentityId.ts

@@ -11,7 +11,7 @@ import {
     DEFAULT_MANAGED_IDENTITY_ID,
     ManagedIdentityIdType,
 } from "../utils/Constants.js";
-import { ManagedIdentityIdParams } from "./Configuration.js";
+import type { ManagedIdentityIdParams } from "./Configuration.js";
 
 export class ManagedIdentityId {
     private _id: string;

shared-configs/eslint-config-msal/index.js

@@ -81,6 +81,7 @@ module.exports = {
         ],
         "import/first": 2,
         "import/no-commonjs": 2,
+        "import/no-cycle": 2,
         "import/no-duplicates": 2,
         "import/no-extraneous-dependencies": 2,
         "import/no-unresolved": 2,