Skip to content

Commit 28a5af1

Browse files
jennyf19jennyf19
authored
fix warnings in idweb and readd warnings as errors (#3173)
* add no warn for preview packages NU5104 * no warn on net7 * re-add warnings as error * remove net7 in tests * move tool to net8 * add no warn on MSGraphBeta package
1 parent 8563cf9 commit 28a5af1

File tree

23 files changed

+41
-36
lines changed

23 files changed

+41
-36
lines changed

‎Directory.Build.props‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
<EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
3737
<LangVersion>13</LangVersion>
3838
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
39+
<NoWarn>$(NoWarn);NETSDK1138</NoWarn>
3940
</PropertyGroup>
4041

4142
<PropertyGroup Condition="'$(TargetFrameworkIdentifier)' == 'NET6_0_OR_GREATER'">

‎build/template-publish-and-cleanup.yaml‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,5 +50,12 @@ steps:
5050
GdnPublishTsaConfigFile: '$(Build.SourcesDirectory)/build/tsaConfig.json'
5151
continueOnError: true
5252

53+
- task: BuildQualityChecks@9
54+
displayName: 'Check Warnings'
55+
inputs:
56+
checkWarnings: true
57+
warningFailOption: 'build'
58+
showStatistics: true
59+
5360
- task: mspremier.PostBuildCleanup.PostBuildCleanup-task.PostBuildCleanup@3
5461
displayName: 'Clean Agent Directories'

‎src/Microsoft.Identity.Web.GraphServiceClientBeta/Microsoft.Identity.Web.GraphServiceClientBeta.csproj‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<Project Sdk="Microsoft.NET.Sdk">
1+
<Project Sdk="Microsoft.NET.Sdk">
22
<PropertyGroup>
33

44
<Title>Microsoft Identity Web, Microsoft Graph v5+ helper</Title>
@@ -11,6 +11,7 @@
1111
<ProjectGuid>{608F0E0B-A52D-4E0F-9B1A-BA9BDA866484}</ProjectGuid>
1212
<PackageValidationBaselineVersion>2.12.2</PackageValidationBaselineVersion>
1313
<PackageReadmeFile>README.md</PackageReadmeFile>
14+
<NoWarn>$(NoWarn);NU5104</NoWarn>
1415
</PropertyGroup>
1516
<ItemGroup>
1617
<None Include="..\..\README.md">

‎src/Microsoft.Identity.Web.MicrosoftGraphBeta/Microsoft.Identity.Web.MicrosoftGraphBeta.csproj‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<Project Sdk="Microsoft.NET.Sdk">
1+
<Project Sdk="Microsoft.NET.Sdk">
22
<PropertyGroup>
33

44
<Title>Microsoft Identity Web, Microsoft Graph helper</Title>
@@ -9,6 +9,7 @@
99
that call Microsoft Graph Beta.
1010
</Description>
1111
<PackageReadmeFile>README.md</PackageReadmeFile>
12+
<NoWarn>$(NoWarn);NU5104</NoWarn>
1213
</PropertyGroup>
1314

1415
<ItemGroup>

‎tests/DevApps/AjaxCallActionsWithDynamicConsent/AjaxCallActionsWithDynamicConsent.csproj‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
<Project Sdk="Microsoft.NET.Sdk.Web">
1+
<Project Sdk="Microsoft.NET.Sdk.Web">
22

33
<PropertyGroup>
4-
<NoWarn>NU1605</NoWarn>
4+
<NoWarn>$(NoWarn);NETSDK1138;NU1605</NoWarn>
55
</PropertyGroup>
66

77
<ItemGroup>

‎tests/DevApps/Directory.Build.props‎

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<Project>
22

33
<PropertyGroup>
4-
<TargetFrameworks>net6.0; net7.0; net8.0; net9.0</TargetFrameworks>
4+
<TargetFrameworks>net6.0; net8.0; net9.0</TargetFrameworks>
55
<TargetFrameworks Condition="'$(TargetNetNext)'== 'True'">$(TargetFrameworks); </TargetFrameworks>
66
<UseWip>true</UseWip>
77
<IsPackable>false</IsPackable>
@@ -13,11 +13,6 @@
1313
<SystemDrawingCommon>6.0.0</SystemDrawingCommon>
1414
</PropertyGroup>
1515

16-
<PropertyGroup Condition="'$(TargetFramework)' == 'net7.0'">
17-
<!--CVE-2021-24112 from ASpNetCore.Protection, and Redis-->
18-
<SystemDrawingCommon>7.0.0</SystemDrawingCommon>
19-
</PropertyGroup>
20-
2116
<PropertyGroup Condition="'$(TargetFramework)' == 'net8.0'">
2217
<!--CVE-2021-24112 from ASpNetCore.Protection, and Redis-->
2318
<SystemDrawingCommon>8.0.0</SystemDrawingCommon>

‎tests/DevApps/aspnet-mvc/OwinWebApi/Web.config‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
</dependentAssembly>
3535
<dependentAssembly>
3636
<assemblyIdentity name="System.Text.Json" publicKeyToken="CC7B13FFCD2DDD51" culture="neutral"/>
37-
<bindingRedirect oldVersion="0.0.0.0-8.0.0.4" newVersion="8.0.0.4"/>
37+
<bindingRedirect oldVersion="0.0.0.0-8.0.0.5" newVersion="8.0.0.5"/>
3838
</dependentAssembly>
3939
<dependentAssembly>
4040
<assemblyIdentity name="System.Text.Encodings.Web" publicKeyToken="CC7B13FFCD2DDD51" culture="neutral"/>
@@ -62,7 +62,7 @@
6262
</dependentAssembly>
6363
<dependentAssembly>
6464
<assemblyIdentity name="System.IdentityModel.Tokens.Jwt" publicKeyToken="31BF3856AD364E35" culture="neutral"/>
65-
<bindingRedirect oldVersion="0.0.0.0-8.1.0.0" newVersion="8.1.0.0"/>
65+
<bindingRedirect oldVersion="0.0.0.0-8.3.0.0" newVersion="8.3.0.0"/>
6666
</dependentAssembly>
6767
<dependentAssembly>
6868
<assemblyIdentity name="System.Diagnostics.DiagnosticSource" publicKeyToken="CC7B13FFCD2DDD51" culture="neutral"/>
@@ -78,31 +78,31 @@
7878
</dependentAssembly>
7979
<dependentAssembly>
8080
<assemblyIdentity name="Microsoft.IdentityModel.Tokens" publicKeyToken="31BF3856AD364E35" culture="neutral"/>
81-
<bindingRedirect oldVersion="0.0.0.0-8.1.0.0" newVersion="8.1.0.0"/>
81+
<bindingRedirect oldVersion="0.0.0.0-8.3.0.0" newVersion="8.3.0.0"/>
8282
</dependentAssembly>
8383
<dependentAssembly>
8484
<assemblyIdentity name="Microsoft.IdentityModel.Protocols.WsFederation" publicKeyToken="31BF3856AD364E35" culture="neutral"/>
8585
<bindingRedirect oldVersion="0.0.0.0-5.5.0.0" newVersion="5.5.0.0"/>
8686
</dependentAssembly>
8787
<dependentAssembly>
8888
<assemblyIdentity name="Microsoft.IdentityModel.Protocols.OpenIdConnect" publicKeyToken="31BF3856AD364E35" culture="neutral"/>
89-
<bindingRedirect oldVersion="0.0.0.0-8.1.0.0" newVersion="8.1.0.0"/>
89+
<bindingRedirect oldVersion="0.0.0.0-8.3.0.0" newVersion="8.3.0.0"/>
9090
</dependentAssembly>
9191
<dependentAssembly>
9292
<assemblyIdentity name="Microsoft.IdentityModel.Protocols" publicKeyToken="31BF3856AD364E35" culture="neutral"/>
93-
<bindingRedirect oldVersion="0.0.0.0-8.1.0.0" newVersion="8.1.0.0"/>
93+
<bindingRedirect oldVersion="0.0.0.0-8.3.0.0" newVersion="8.3.0.0"/>
9494
</dependentAssembly>
9595
<dependentAssembly>
9696
<assemblyIdentity name="Microsoft.IdentityModel.Logging" publicKeyToken="31BF3856AD364E35" culture="neutral"/>
97-
<bindingRedirect oldVersion="0.0.0.0-8.1.0.0" newVersion="8.1.0.0"/>
97+
<bindingRedirect oldVersion="0.0.0.0-8.3.0.0" newVersion="8.3.0.0"/>
9898
</dependentAssembly>
9999
<dependentAssembly>
100100
<assemblyIdentity name="Microsoft.IdentityModel.Abstractions" publicKeyToken="31BF3856AD364E35" culture="neutral"/>
101-
<bindingRedirect oldVersion="0.0.0.0-8.1.0.0" newVersion="8.1.0.0"/>
101+
<bindingRedirect oldVersion="0.0.0.0-8.3.0.0" newVersion="8.3.0.0"/>
102102
</dependentAssembly>
103103
<dependentAssembly>
104104
<assemblyIdentity name="Microsoft.Identity.Client" publicKeyToken="0A613F4DD989E8AE" culture="neutral"/>
105-
<bindingRedirect oldVersion="0.0.0.0-4.65.2.0" newVersion="4.65.2.0"/>
105+
<bindingRedirect oldVersion="0.0.0.0-4.66.1.0" newVersion="4.66.1.0"/>
106106
</dependentAssembly>
107107
<dependentAssembly>
108108
<assemblyIdentity name="Microsoft.Extensions.Primitives" publicKeyToken="ADB9793829DDAE60" culture="neutral"/>

‎tests/DevApps/daemon-app/Daemon-app/Daemon-app.csproj‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
<PropertyGroup>
44
<OutputType>Exe</OutputType>
5-
<TargetFrameworks>net7.0</TargetFrameworks>
5+
<TargetFrameworks>net8.0</TargetFrameworks>
66
<RootNamespace>Daemon_app</RootNamespace>
77
<ImplicitUsings>enable</ImplicitUsings>
88
<Nullable>enable</Nullable>

‎tests/DevApps/daemon-app/daemon-console-calling-downstreamApi/DaemonConsoleCallingDownstreamApi.csproj‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
<PropertyGroup>
44
<OutputType>Exe</OutputType>
5-
<TargetFrameworks>net7.0</TargetFrameworks>
5+
<TargetFrameworks>net8.0</TargetFrameworks>
66
<ImplicitUsings>enable</ImplicitUsings>
77
<Nullable>enable</Nullable>
88
<UseWip>true</UseWip>

‎tests/DevApps/daemon-app/daemon-console-calling-msgraph/DaemonConsoleCallingMsGraph.csproj‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
<PropertyGroup>
44
<OutputType>Exe</OutputType>
5-
<TargetFrameworks>net7.0</TargetFrameworks>
5+
<TargetFrameworks>net8.0</TargetFrameworks>
66
<ImplicitUsings>enable</ImplicitUsings>
77
<Nullable>enable</Nullable>
88
</PropertyGroup>

0 commit comments

Comments
 (0)