Seems to compile

Author: 1RyanK

benchmark_v2/optional/concatenate_uniquely_benchmark.py

@@ -11,7 +11,8 @@
 
 # 1 => ak.unique(ak.concatenate([a, b], ordered=False))
 # 2 => Strings.concatenate_uniquely([a, b])
-METHOD = (1, 2)
+# 3 => Strings.concatenate_uniquely_with_inner_arrays([a, b])
+METHOD = (1, 2, 3)
 
 
 def _unique_concat(a: Strings, b: Strings) -> Strings:
@@ -22,6 +23,10 @@ def _concatenate_uniquely(a: Strings, b: Strings) -> Strings:
     return Strings.concatenate_uniquely([a, b])
 
 
+def _concatenate_uniquely_inner_arrays(a: Strings, b: Strings) -> Strings:
+    return Strings.concatenate_uniquely_with_inner_arrays([a, b])
+
+
 @pytest.mark.skip_numpy(True)
 @pytest.mark.benchmark(group="AK_strings_concat_unique")
 @pytest.mark.parametrize("overlap", OVERLAP)
@@ -76,7 +81,8 @@ def bench_strings_concat_unique(benchmark, overlap, method):
     bytes_b = calc_num_bytes(b)
     num_bytes = bytes_a + bytes_b
 
-    fn = _unique_concat if method == 1 else _concatenate_uniquely
+    fns = [_unique_concat, _concatenate_uniquely, _concatenate_uniquely_inner_arrays]
+    fn = fns[method]
 
     benchmark.pedantic(
         fn,

src/ConcatenateMsg.chpl

@@ -691,7 +691,7 @@ module ConcatenateMsg
                     var locSet = new set(string, parSafe = true);
 
                     // Reduce to unique strings within this locale
-                    forall str in myStrings {
+                    forall str in myStrings with (ref locSet) {
                         locSet.add(str);
                     }
 
@@ -724,7 +724,7 @@ module ConcatenateMsg
             var strSet = new set(string, parSafe = true);
 
             // Perform another reduction by uniqueness on the strings in this set
-            forall str in myStrings {
+            forall str in myStrings with (ref strSet) {
               strSet.add(str);
             }