Skip to content

New problems #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 83 commits into from
May 22, 2023
Merged

Conversation

ImogenBits
Copy link
Collaborator

Adjusts the pairsum and biclique problem to work with the new Problem classes. Note that I didn't modify the docs for the biclique problem so they now are massively inaccurate.

@Benezivas Benezivas self-assigned this Jan 20, 2023
@Benezivas
Copy link
Collaborator

Could you please demonstrate how to adapt the new module structure regarding the tests? We will be able to throw most of the original parser tests away, as it makes sense to write generic tests for specific ProblemModels, such as DirectedGraph.

It would be nice (and sufficient) if you could adapt a few of the old tests for the verifier of the biclique problem, I should then be able to adapt the remaining test cases.

@ImogenBits
Copy link
Collaborator Author

ImogenBits commented May 21, 2023

all problems are updated now. Note that they use features from the open PRs in Algobattle since they all seem pretty straightforward, but I'm happy to change them and this repo if you want

@Benezivas
Copy link
Collaborator

Thank you, the only thing left to do is to update the CI workflow, then I would merge this into the develop branch until version 4.0.0 of algobattle has been released.

@Benezivas Benezivas changed the base branch from main to develop May 22, 2023 12:41
@ImogenBits
Copy link
Collaborator Author

Updated them, you need to manually approve them to run

@Benezivas
Copy link
Collaborator

Thank you, I have also adjusted workflows to be manually triggered only for new Accounts.

@Benezivas Benezivas merged commit 0965dab into Algorithmic-Battle:develop May 22, 2023
@ImogenBits ImogenBits deleted the new_problems branch May 22, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants