Passes snippets/synapse.py https://gitlab.com/dilawar/moose-examples/-/issues/1

Author: Dilawar Singh

pybind11/Finfo.cpp

@@ -93,42 +93,36 @@ py::object __Finfo__::getLookupValueFinfoItem(const ObjId& oid, const Finfo* f,
     string srcType = srcDestType[0];
     string tgtType = srcDestType[1];
 
-    py::object r;
+    py::object r = py::none();
 
     if (srcType == "string") {
         auto k = py::cast<string>(key);
-        r = getLookupValueFinfoItemInner<string>(oid, f, k, tgtType);
+        return getLookupValueFinfoItemInner<string>(oid, f, k, tgtType);
     } else if (srcType == "unsigned int") {
         auto k = py::cast<unsigned int>(key);
-        r = getLookupValueFinfoItemInner<unsigned int>(oid, f, k, tgtType);
+        return getLookupValueFinfoItemInner<unsigned int>(oid, f, k, tgtType);
     } else if (srcType == "ObjId") {
         auto k = py::cast<ObjId>(key);
-        r = getLookupValueFinfoItemInner<ObjId>(oid, f, k, tgtType);
+        return getLookupValueFinfoItemInner<ObjId>(oid, f, k, tgtType);
     } else if (srcType == "Id") {
         auto k = py::cast<Id>(key);
-        r = getLookupValueFinfoItemInner<Id>(oid, f, k, tgtType);
+        return getLookupValueFinfoItemInner<Id>(oid, f, k, tgtType);
     } else {
-        r = py::none();
-    }
-
-    if (r.is(py::none())) {
         py::print("getLookupValueFinfoItem::NotImplemented for key:", key,
-                  "srcType:", srcType, "and tgtType:", tgtType, "path: ",
-                  oid.path());
+                "srcType:", srcType, "and tgtType:", tgtType, "path: ",
+                oid.path());
         throw runtime_error("getLookupValueFinfoItem::NotImplemented error");
     }
     return r;
 }
 
 py::object __Finfo__::getItem(const py::object& key)
 {
-    py::print("Fetching value for", key, finfoType_);
     return func_(key);
 }
 
 py::object __Finfo__::operator()(const py::object& key)
 {
-    py::print("Calling function with key", key);
     return func_(key);
 }
 

pybind11/Finfo.h

@@ -45,6 +45,7 @@ class __Finfo__ {
 
         py::print("Warning: Could not find", fname, "for key", key, "(type",
                   tgtType, ") on path ", oid.path());
+        throw py::key_error("Attribute error.");
         return py::none();
     }
 

pybind11/pymoose.cpp

@@ -117,9 +117,7 @@ py::object getFieldGeneric(const ObjId &oid, const string &fieldName)
     auto finfo = cinfo->findFinfo(fieldName);
 
     if (!finfo) {
-        cout << "Error: " << fieldName << " is not found on " << oid.path()
-             << endl;
-        return pybind11::none();
+        throw py::key_error(fieldName + " is not found on '" + oid.path() + "'.");
     }
 
     string finfoType = cinfo->getFinfoType(finfo);