Skip to content

Commit 3f1fc64

Browse files
committed
Work on Bryce's code review comments
1 parent e454dd2 commit 3f1fc64

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

.github/workflows/cpp_extra.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,8 @@ on:
7575
0 0 * * *
7676
workflow_dispatch:
7777
inputs:
78-
odbc_msi_upload:
79-
description: 'ODBC Unsigned MSI Upload'
78+
odbc_release_step:
79+
description: 'ODBC MSI release step'
8080
required: true
8181
default: false
8282
type: boolean
@@ -580,7 +580,7 @@ jobs:
580580
${{
581581
startsWith(github.ref_name, 'apache-arrow-') &&
582582
contains(github.ref_name, '-rc') &&
583-
!inputs.odbc_msi_upload
583+
!inputs.odbc_release_step
584584
}}
585585
timeout-minutes: 240
586586
permissions:
@@ -596,7 +596,7 @@ jobs:
596596
uses: ./.github/actions/odbc-windows
597597
with:
598598
github-token: ${{ secrets.GITHUB_TOKEN }}
599-
- name: Name Unsigned ODBC DLL
599+
- name: Rename Unsigned ODBC DLL
600600
run: |
601601
Rename-Item `
602602
-Path build/cpp/${{ env.ARROW_BUILD_TYPE }}/arrow_flight_sql_odbc.dll `
@@ -642,9 +642,9 @@ jobs:
642642
643643
odbc-msvc-upload-msi:
644644
needs: check-labels
645-
name: ODBC Windows Upload Unsigned MSI
645+
name: ODBC Windows Build & Upload Unsigned MSI
646646
runs-on: windows-2022
647-
if: inputs.odbc_msi_upload
647+
if: inputs.odbc_release_step
648648
timeout-minutes: 240
649649
permissions:
650650
# Upload to GitHub Release

0 commit comments

Comments
 (0)