Improve HookCommandTest

ggcasuso · ggcasuso · commit a5d081dcf573 · 2020-03-11T15:14:52.000+01:00
diff --git a/tests/HookCommandTest.php b/tests/HookCommandTest.php
@@ -24,7 +24,7 @@ public function it_tests_hooks_that_exist()
     /**
      * @test
      */
-    public function it_not_continue_if_previous_hook_fail()
+    public function it_terminates_if_previous_hook_fails()
     {
         $hook = [
             'pre-commit' => [
@@ -38,5 +38,6 @@ public function it_not_continue_if_previous_hook_fail()
 
         $commandTester->execute([]);
         $this->assertContains('execution-error', $commandTester->getDisplay());
+        $this->assertNotContains('before-commit', $commandTester->getDisplay());
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ public function it_tests_hooks_that_exist()`
`24`	`24`	`/**`
`25`	`25`	`* @test`
`26`	`26`	`*/`
`27`		`- public function it_not_continue_if_previous_hook_fail()`
	`27`	`+ public function it_terminates_if_previous_hook_fails()`
`28`	`28`	`{`
`29`	`29`	`$hook = [`
`30`	`30`	`'pre-commit' => [`
`@@ -38,5 +38,6 @@ public function it_not_continue_if_previous_hook_fail()`
`38`	`38`
`39`	`39`	`$commandTester->execute([]);`
`40`	`40`	`$this->assertContains('execution-error', $commandTester->getDisplay());`
	`41`	`+ $this->assertNotContains('before-commit', $commandTester->getDisplay());`
`41`	`42`	`}`
`42`	`43`	`}`