Add test debugging setup #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bearfriend
commented
Jun 16, 2023
| @@ -23,7 +23,7 @@ export async function reset(opts) { | |||
|
|
|||
| window.scroll(0, 0); | |||
|
|
|||
| await sendMouse({ type: 'move', position: [0, 0] }); | |||
| await sendMouse({ type: 'move', position: [0, 0] }).catch(() => {}); | |||
There was a problem hiding this comment.
In manual mode, tests are run in your existing browser installs, which can't be controlled this way, so simply ignoring the failures here, though a console warning may be good. These work fine in watch mode.
bearfriend
commented
Jun 16, 2023
Comment on lines
+17
to
+19
| { name: 'grep', alias: 'g', type: String }, | ||
| { name: 'filter', alias: 'f', type: String, multiple: true }, |
There was a problem hiding this comment.
grep now just forwards to the mocha config and works as it does in the existing library. filter (open to other names) will do what grep was doing previously: filter test files so you can run your tests in 2 seconds instead of 20.
dlockhart
reviewed
Jun 16, 2023
| const { watch, manual, group, files, playwright } = this.#cliArgs; | ||
|
|
||
| if (!group || group === 'default') { | ||
| if (playwright) { |
There was a problem hiding this comment.
Haha, just wrapping their CLI is looking better and better each time I look at these warnings...
dlockhart
force-pushed
the
dgleckler/manual-pause
branch
from
931d3c7 to
24410f0
Compare
|
🎉 This PR is included in version 0.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just some basic setup to be able to run
--watchand--manual, including automatically pausing in DevTools at the top of each test file.We can still decide to implement a UI-based play/pause/next system with promises, so I'll link this to US152298 (Visual-diff: ability to debug in the browser), but won't consider it done.