US152271 - Cleanup appropriate folders in the plugin during runs #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svanherk
commented
Jun 21, 2023
src/server/visual-diff-plugin.js
Outdated
Comment on lines
64
to
107
| const goldenFileName = `${join(rootDir, '.vdiff', testPath, 'golden', browser, dir, newName)}.png`; | ||
| const passFileName = `${join(rootDir, '.vdiff', testPath, 'pass', browser, dir, newName)}.png`; | ||
| const screenshotFileName = `${join(rootDir, '.vdiff', testPath, 'fail', browser, dir, newName)}.png`; | ||
| const newPath = join(rootDir, '.vdiff', testPath, dir); | ||
| const goldenFileName = `${join(newPath, 'golden', browser, newName)}.png`; | ||
| const passFileName = `${join(newPath, 'pass', browser, newName)}.png`; | ||
| const screenshotFileName = `${join(newPath, 'fail', browser, newName)}.png`; |
There was a problem hiding this comment.
This switches to the new directory structure we settled on in slack
svanherk
commented
Jun 21, 2023
|
|
||
| const isCI = !!env['CI']; |
There was a problem hiding this comment.
Added this to make CI as quick as possible, but we could leave it out if we'd rather keep things simple. It'll just search for fail, pass, and reports that won't exist.
dlockhart
reviewed
Jun 21, 2023
And I think we'll need some kind of info manager to pass things between the plugin and the reporter for that, and that manager can own the name for |
Co-authored-by: Dave Lockhart <[email protected]>
…spaceUI/testing into US152271_Cleanup_Folders_Option_2
dlockhart
approved these changes
Jun 22, 2023
bearfriend
reviewed
Jun 22, 2023
bearfriend
reviewed
Jun 22, 2023
bearfriend
approved these changes
Jun 22, 2023
|
🎉 This PR is included in version 0.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Option 2 - alternative to #32.
After using both I prefer this one - the things that get cleared "make sense" and feel intuitive, whereas the other solution has some compromises.