add golangci-lint to makefile

cyrilou242 · cyrilou242 · commit b86d1b9e5751 · 2026-04-15T23:09:32.000+02:00
diff --git a/Makefile b/Makefile
@@ -13,6 +13,10 @@ vet:
 test:
 	go test ./...
 
+.PHONY: lint
+lint:
+	golangci-lint run
+
 .PHONY: build
 build:
 	go build -o bin/clickhouse-go-linter .
diff --git a/passes/chbatchclose/chbatchclose.go b/passes/chbatchclose/chbatchclose.go
@@ -64,7 +64,7 @@ func (b *batchUsage) report(varName string, pass *analysis.Pass) {
 		// no usage of rows.Next()
 		return
 	}
-	if !(b.deferredClose || b.returned) {
+	if !b.deferredClose && !b.returned {
 		pass.Reportf(b.assignPos,
 			"clickhouse Batch %s must be closed defensively with defer %s.Close() after successful instantiation",
 			varName, varName)

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ func (b batchUsage) report(varName string, pass analysis.Pass) {`
`64`	`64`	`// no usage of rows.Next()`
`65`	`65`	`return`
`66`	`66`	`}`
`67`		`- if !(b.deferredClose \|\| b.returned) {`
	`67`	`+ if !b.deferredClose && !b.returned {`
`68`	`68`	`pass.Reportf(b.assignPos,`
`69`	`69`	`"clickhouse Batch %s must be closed defensively with defer %s.Close() after successful instantiation",`
`70`	`70`	`varName, varName)`