Skip to content

Commit e959fb0

Browse files
committed
Add REQUEST_TIME and REQUEST_TIME_FLOAT as allowed offsets
1 parent db76246 commit e959fb0

File tree

3 files changed

+12
-3
lines changed

3 files changed

+12
-3
lines changed

src/Rules/Superglobals/SuperglobalRuleHelper.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ final class SuperglobalRuleHelper
2121
* @var array{_SERVER: list<string>, _GET: list<string>}
2222
*/
2323
private static array $allowedOffsetAccess = [
24-
'_SERVER' => ['argv', 'argc'],
24+
'_SERVER' => ['argv', 'argc', 'REQUEST_TIME', 'REQUEST_TIME_FLOAT'],
2525
'_GET' => [],
2626
];
2727

tests/Rules/Superglobals/data/superglobal-access-cases.php

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,14 @@ function bar(string $c): ?string
3232
}
3333

3434
/**
35-
* @return array{array<string, mixed>, int}
35+
* @return array{list<string>, int, int, float}
3636
*/
3737
function allowed_offset_access(): array
3838
{
39-
return [$_SERVER['argv'] ?? [], $_SERVER['argc'] ?? 0];
39+
return [
40+
$_SERVER['argv'] ?? [],
41+
$_SERVER['argc'] ?? 0,
42+
$_SERVER['REQUEST_TIME'] ?? 0,
43+
$_SERVER['REQUEST_TIME_FLOAT'] ?? 0.0,
44+
];
4045
}

tests/Rules/Superglobals/data/superglobal-assign-cases.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,4 +46,8 @@ function allowed_offset_assigns(): void
4646
{
4747
$_SERVER['argv'] = ['arg1', 'arg2'];
4848
$_SERVER['argc'] = 2;
49+
50+
$_SERVER['REQUEST_TIME'] = time();
51+
52+
$_SERVER['REQUEST_TIME_FLOAT'] = microtime(true);
4953
}

0 commit comments

Comments
 (0)