Skip to content

Commit 3a82afc

Browse files
author
Loïc Mangeonjean
committed
fix: typos
1 parent c514fe2 commit 3a82afc

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -327,7 +327,7 @@ See the [VSCode Server](https://github.com/CodinGame/monaco-vscode-api/wiki/How-
327327

328328
The library supports shadow-dom.
329329

330-
⚠️ VSCode itself does support shadow dom, and there are multiple parts that needed to be patched in order for it to work.
330+
⚠️ VSCode itself doesn't support shadow dom, and there are multiple parts that needed to be patched in order for it to work.
331331

332332
There are multiple benefits of using it:
333333
- Your custom global style won't impact the VSCode workbench style (for instance if you did override the default [box-sizing](https://developer.mozilla.org/en-US/docs/Web/CSS/box-sizing))
@@ -342,7 +342,7 @@ If the provided container element is a child of a shadow dom element, the styles
342342

343343
In order to be able to load the static css files in the shadow dom as well. Your bundler configuration needs to be adapted so that importing css files doesn't load their content in the page head, but instead just returns the file content as default (either as a string or a `CSSStyleSheet`). It can be achieved with most bundlers with some configurations.
344344

345-
Note that the bundler should still resolve references assets in the css files, so you can just the `raw` loader, on the `assets/source` webpack module type.
345+
Note that the bundler should still resolve referenced assets in the css files, so you can't just use the `raw` loader, or the `assets/source` webpack module type.
346346

347347
#### Webpack
348348

docs/vscode_monaco_upgrade.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
- Update dependencies
3131
- Implement improvements dependening on the new features available from vscode (optional)
3232
- Don't forget to check the `Window` output (in the `OUTPUT` panel tab) to check for errors
33-
- Check all possibile combinations
33+
- Check all possible combinations
3434
- Full workbench mode or not
3535
- Shadow dom mode or not
3636
- Using VSCode server

0 commit comments

Comments
 (0)