chore(tests): add glslang for validation

Author: CodyJasonBennett

.gitignore

@@ -1,6 +1,7 @@
 .DS_Store
 node_modules
 dist
+tests/shaders/bin
 
 # Editor directories and files
 .idea

package.json

@@ -26,7 +26,13 @@
   "exports": "./dist/index.js",
   "sideEffects": false,
   "devDependencies": {
+    "@types/decompress": "^4.2.7",
+    "@types/download": "^8.0.5",
     "@types/node": "^24.6.2",
+    "decompress": "^4.2.1",
+    "download": "^8.0.0",
+    "rimraf": "^6.0.1",
+    "temp-dir": "^3.0.0",
     "typescript": "^5.9.3",
     "vite": "^7.1.8",
     "vitest": "^3.2.4"

tests/index.test.ts

@@ -1,5 +1,9 @@
 import { describe, it, expect } from 'vitest'
 import { tokenize, minify } from 'shaderkit'
+import { glslang } from './shaders/glslang'
+import * as fs from 'node:fs'
+import * as path from 'node:path'
+import { rimrafSync } from 'rimraf'
 
 const glsl = /* glsl */ `#version 300 es
   precision mediump float;
@@ -190,4 +194,21 @@ describe('minify', () => {
     expect(minify(shader, { mangle: true, mangleExternals: true, mangleMap })).toMatchSnapshot()
     expect(mangleMap).toMatchSnapshot()
   })
+
+  it('validates mangling works correctly with glslang', () => {
+    glslang('tests/shaders/test.frag')
+
+    const shader = fs.readFileSync(path.resolve(process.cwd(), 'tests/shaders/test.frag'), { encoding: 'utf-8' })
+    const minified = minify(shader, { mangle: true, mangleExternals: true })
+    fs.writeFileSync(path.resolve(process.cwd(), 'tests/shaders/test.min.frag'), minified, { encoding: 'utf-8' })
+
+    try {
+      glslang('tests/shaders/test.min.frag')
+    } catch (error: any) {
+      error.message = '\n' + minified + '\n\n' + error.message
+      throw error
+    } finally {
+      rimrafSync(path.resolve(process.cwd(), 'tests/shaders/test.min.frag'))
+    }
+  })
 })

tests/shaders/glslang.ts

@@ -0,0 +1,53 @@
+import * as fs from 'node:fs'
+import * as os from 'node:os'
+import * as path from 'node:path'
+import * as url from 'node:url'
+import { execFileSync } from 'node:child_process'
+import download from 'download'
+import tempDirRoot from 'temp-dir'
+import extract from 'decompress'
+import { rimrafSync } from 'rimraf'
+
+const platform = os.platform()
+const arch = os.arch()
+if (platform !== 'linux' && platform !== 'darwin' && platform !== 'win32') {
+  throw new Error(`Unsupported platform: ${platform}`)
+}
+if (!(arch === 'x64' || (arch === 'arm64' && platform === 'darwin'))) {
+  throw new Error(`Unsupported architecture: ${arch}`)
+}
+
+const filenames = {
+  darwin: 'glslang-master-osx-Release',
+  linux: 'glslang-master-linux-Release',
+  win32: 'glslang-master-windows-x64-Release',
+}
+
+const dirname = path.dirname(url.fileURLToPath(import.meta.url))
+const filename = filenames[platform]
+const suffix = platform === 'win32' ? '.exe' : ''
+const archiveURL = `https://github.com/KhronosGroup/glslang/releases/download/master-tot/${filename}.zip`
+const tempDir = path.resolve(tempDirRoot, 'glslang-validator-prebuilt')
+const zipPath = path.resolve(tempDir, `${filename}.zip`)
+const unzippedBinPath = path.resolve(tempDir, `bin/glslangValidator${suffix}`)
+const dstBinPath = path.resolve(dirname, `bin/glslangValidator${suffix}`)
+const dstBinDir = path.resolve(dirname, `bin`)
+
+if (!fs.existsSync(dstBinPath)) {
+  rimrafSync(tempDir)
+  fs.mkdirSync(tempDir, { recursive: true })
+  await download(archiveURL, tempDir)
+  await extract(zipPath, tempDir)
+  rimrafSync(dstBinDir)
+  fs.mkdirSync(dstBinDir, { recursive: true })
+  fs.copyFileSync(unzippedBinPath, dstBinPath)
+  fs.chmodSync(dstBinPath, '755')
+}
+
+export function glslang(...args: string[]): void {
+  try {
+    execFileSync(dstBinPath, args.length === 0 ? ['--version'] : args, { encoding: 'utf-8' })
+  } catch (error: any) {
+    throw new Error(error.stdout)
+  }
+}

tests/shaders/test.frag

@@ -0,0 +1,65 @@
+#version 300 es
+precision mediump float;
+
+// single line
+
+/*
+  multiline
+*/
+
+#define PLUS (n) \
+  n += 1
+
+#define TEST // inline comment
+#if defined( TEST )
+  const bool isTest = true;
+#endif
+
+uniform float foo, bar;
+
+uniform sampler2D map;
+in vec2 vUv;
+out vec4 pc_FragColor;
+
+// #include <three_test>
+
+layout(std140) uniform Uniforms1 {
+  mat4 projectionMatrix;
+  mat4 modelViewMatrix;
+  mat3 normalMatrix;
+  float one, two;
+};
+
+layout(std140) uniform Uniforms2 {
+  mat4 projectionMatrix;
+  mat4 modelViewMatrix;
+  mat3 normalMatrix;
+  float one, two;
+} globals;
+
+struct X {
+  #if !defined(BLA)
+    int y;
+  #else
+    float z;
+  #endif
+};
+
+struct LightData {
+  float intensity;
+  vec3 position;
+  float one, two;
+};
+uniform LightData Light[4];
+
+invariant pc_FragColor;
+
+void main() {
+  vec4 lightNormal = vec4(Light[0].position.xyz * Light[0].intensity, 0.0);
+  vec4 clipPosition = projectionMatrix * modelViewMatrix * vec4(0, 0, 0, 1);
+  vec4 clipPositionGlobals = globals.projectionMatrix * globals.modelViewMatrix * vec4(0, 0, 0, 1);
+  if (false) {}
+  pc_FragColor = vec4(texture(map, vUv).rgb, 0.0);
+  float bar = 0.0;
+  pc_FragColor.a += 1.0+bar;
+}