fix bogus 404 errors for sidebar toolbar icons

Sidebar JSDialog toolbox items send icon names with LO's 'sc_'
(small-command) prefix, but COOL only has 'lc_' (large-command)
icons, resulting in requests for non-existent files like
lc_sc_changecasetoupper.svg.

The data.icon code path in _unoToolButton bypassed
getIconNameOfCommand entirely, so normalize it through that
function to apply sc_ prefix stripping and alias resolution.

Also:
- skip legacy LO resource IDs (like sr20006)
- add icon aliases: insertfooter, textbodyparastyle,
  showmultiplepages, showtwopages, validatedialogsa11y,
  validatesidebara11y
- add changecasetoupper icon (light + dark) from colibre theme
- add dark mode icon for ai_sidebar

Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I6a91b161af0269330265822440c3f0a87fbb104b

Author: timar

browser/images/dark/lc_ai_sidebar.svg

@@ -406,11 +406,16 @@ class LOUtil {
 		}
 
 		// Skip icon lookup for numeric-only IDs (JSDialog artifacts like 1, 5, 65535)
-		if (/^\d+$/.test(cleanName)) return '';
+		// and LO StarRes resource IDs (like sr20006)
+		if (/^\d+$/.test(cleanName) || /^sr\d+$/.test(cleanName)) return '';
 
 		// Skip icon lookup for overflow button pseudo-commands
 		if (cleanName.startsWith('overflow-button-')) return '';
 
+		// Strip 'sc_' prefix from sidebar controller command names
+		// (LO's small-command icon prefix that doesn't apply to COOL)
+		if (cleanName.startsWith('sc_')) cleanName = cleanName.substring(3);
+
 		var iconURLAliases: IconNameMap = {
 			// lc_closemobile.svg is generated when loading in NB mode then
 			// switch to compact mode: 1st hidden element in the top toolbar
@@ -432,6 +437,7 @@ class LOUtil {
 			formatsparklinemenu: 'insertsparkline',
 			insertdatecontentcontrol: 'datefield',
 			editheaderandfooter: 'headerandfooter',
+			insertfooter: 'insertpagefooter',
 			exportas: 'saveas',
 			insertheaderfooter: 'headerandfooter',
 			previoustrackedchange: 'prevrecord',
@@ -456,6 +462,7 @@ class LOUtil {
 			insertrowsafter: 'insertrowsmenu',
 			insertobjectchart: 'drawchart',
 			textpropertypanel: 'sidebartextpanel',
+			textbodyparastyle: 'parastyle',
 			spacepara15: 'linespacing',
 			orientationdegrees: 'rotation',
 			clearoutline: 'delete',
@@ -527,6 +534,8 @@ class LOUtil {
 			tableautofitmenu: 'columnwidth',
 			menucolumnwidth: 'columnwidth',
 			hyphenation: 'hyphenate',
+			validatedialogsa11y: 'validation',
+			validatesidebara11y: 'validation',
 			objectbackone: 'behindobject',
 			deleteannotation: 'deletenote',
 			areapropertypanel: 'chartareapanel',
@@ -631,6 +640,8 @@ class LOUtil {
 			graphicfiltersharpen: 'graphicfiltersharpen',
 			graphicfiltersobel: 'graphicfiltersobel',
 			effects: 'pictureeffectsmenu',
+			showmultiplepages: 'multipageview',
+			showtwopages: 'multipageview',
 			fitwidthzoom: 'pagewidth',
 			open: 'formularesfapopen',
 			'exportas-pdf': 'exportpdf',

browser/images/dark/lc_changecasetoupper.svg

@@ -1915,7 +1915,22 @@ window.L.Control.JSDialogBuilder = window.L.Control.extend({
 			else if (hasImage !== false){
 				if (data.icon) {
 					buttonImage = window.L.DomUtil.create('img', '', button);
-					this._isStringCloseToURL(data.icon) ? buttonImage.src = data.icon : app.LOUtil.setImage(buttonImage, data.icon, builder.map);
+					if (this._isStringCloseToURL(data.icon)) {
+						buttonImage.src = data.icon;
+					} else {
+						// Normalize LO icon filenames through getIconNameOfCommand
+						// to apply sc_ prefix stripping and alias resolution
+						var normalizedIcon = data.icon;
+						var iconMatch = data.icon.match(/^lc_(.+)\.svg$/);
+						if (iconMatch) {
+							normalizedIcon = app.LOUtil.getIconNameOfCommand(iconMatch[1], true);
+						}
+						if (normalizedIcon) {
+							app.LOUtil.setImage(buttonImage, normalizedIcon, builder.map);
+						} else {
+							buttonImage = false;
+						}
+					}
 				}
 				else if (data.image) {
 					buttonImage = window.L.DomUtil.create('img', '', button);