[PROD-13928] Make Runner.datasetList optional again #807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requiring it breaks the updateRunner endpoint, or at minima forces users to provide that field (with current values) even if that's not the field they want to modify. This should be fixed in a better way when we find the time to rework the API contract and split the data model for creation, update and reading.
sjoubert
force-pushed
the
revert_runner_datasetlist_requirement_PROD-13928
branch
from
8367b07 to
4ba1abd
Compare
sjoubert
deleted the
revert_runner_datasetlist_requirement_PROD-13928
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requiring it breaks the updateRunner endpoint, or at minima forces users to provide that field (with current values) even if that's not the field they want to modify.
This should be fixed in a better way when we find the time to rework the API contract and split the data model for creation, update and reading.