fix: check filenames as we do for destination paths #827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -215,6 +215,10 @@ internal class WorkspaceServiceImpl( | |||
| throw IllegalArgumentException("Invalid destination: '$destination'. '..' is not allowed") | |||
| } | |||
| val workspace = getVerifiedWorkspace(organizationId, workspaceId, PERMISSION_WRITE) | |||
| if (file?.filename?.contains("..") == true || file?.filename?.contains("/") == true) { | |||
There was a problem hiding this comment.
Would it be useful to check for "" too ?
There was a problem hiding this comment.
The quote is a possible character for a filename (even though not very useful), and since it cannot be abused to write to a different location I think we should keep it
Leopold-Cramer
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.