Lcra/rework data objects organization openapi prod 14189 #850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… conventions - Changed collection GET endpoints to use 'list' prefix - Changed single resource GET endpoints to use 'get' prefix - Changed POST endpoints to use 'create' prefix - Changed DELETE endpoints to use 'delete' prefix - Updated security-related operation names for consistency - Maintained existing operation IDs that already followed conventions
…quests and responses - Created separate request/response objects for CRUD operations - Created separate request/response objects for security operations - Created comprehensive Organization object that includes all information - Updated all endpoints to use appropriate request/response schemas - Maintained backward compatibility while improving API structure
Leopold-Cramer
force-pushed
the
LCRA/rework_dataObjects_organization_openapi_PROD-14189
branch
from
91ad7da to
31854d0
Compare
sjoubert
requested changes
Jan 22, 2025
jreynard-code
requested changes
Jan 22, 2025
...egrationTest/kotlin/com/cosmotech/organization/service/OrganizationServiceIntegrationTest.kt
Show resolved
Hide resolved
...egrationTest/kotlin/com/cosmotech/organization/service/OrganizationServiceIntegrationTest.kt
Show resolved
Hide resolved
...egrationTest/kotlin/com/cosmotech/organization/service/OrganizationServiceIntegrationTest.kt
Outdated
Show resolved
Hide resolved
organization/src/main/kotlin/com/cosmotech/organization/service/OrganizationServiceImpl.kt
Show resolved
Hide resolved
workspace/src/test/kotlin/com/cosmotech/workspace/service/WorkspaceServiceImplTests.kt
Show resolved
Hide resolved
sjoubert
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
It's ok for me. One thing we'll need to do at some point is clean all the generated markdown files for the doc. The build process automatically generate new one but does not clean the removed files. For example, in the PR we have both UpdateOrganizationRequest.md and OrganizationUpdateRequest.md due to a rename during dev.
You can manually clean these if you want but I'm sure there plenty more left to clean. This should be fixed in the build system directly.
Leopold-Cramer
deleted the
LCRA/rework_dataObjects_organization_openapi_PROD-14189
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.