Skip to content

Lcra/refactor workspace openapi prod 14206 #858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 19, 2025

Conversation

Leopold-Cramer
Copy link
Contributor

No description provided.

@Leopold-Cramer Leopold-Cramer force-pushed the LCRA/refactor_workspace_openapi1_PROD-14206 branch 3 times, most recently from 6040e8e to ebe6471 Compare January 28, 2025 15:07
Copy link
Member

@jreynard-code jreynard-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some remarks ;)
GJ

Copy link
Member

@jreynard-code jreynard-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some buggy changes.
Go deeper in changes please and add some tests to be sure that it works as it should ;)

@Leopold-Cramer Leopold-Cramer force-pushed the LCRA/refactor_workspace_openapi1_PROD-14206 branch from d09e282 to a9a3700 Compare January 30, 2025 15:12
Copy link
Member

@jreynard-code jreynard-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some work to do but the end is close! Be strong ;)

@Leopold-Cramer Leopold-Cramer force-pushed the LCRA/refactor_workspace_openapi1_PROD-14206 branch from a9a3700 to b50f34e Compare February 10, 2025 14:06
Copy link
Member

@jreynard-code jreynard-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some remarks.
Almost there ;)

@Leopold-Cramer Leopold-Cramer force-pushed the LCRA/refactor_workspace_openapi1_PROD-14206 branch 2 times, most recently from 4eeee5c to 16b2fc2 Compare February 13, 2025 14:45
Copy link
Member

@jreynard-code jreynard-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
GG ;)

@Leopold-Cramer Leopold-Cramer force-pushed the LCRA/refactor_workspace_openapi1_PROD-14206 branch from cb3c768 to 9a34070 Compare February 19, 2025 09:36
@Leopold-Cramer Leopold-Cramer force-pushed the LCRA/refactor_workspace_openapi1_PROD-14206 branch from 9a34070 to 741cad9 Compare February 19, 2025 09:53
@Leopold-Cramer Leopold-Cramer changed the title Lcra/refactor workspace openapi1 prod 14206 Lcra/refactor workspace openapi prod 14206 Feb 19, 2025
@Leopold-Cramer Leopold-Cramer merged commit 9d7624d into main Feb 19, 2025
33 checks passed
@Leopold-Cramer Leopold-Cramer deleted the LCRA/refactor_workspace_openapi1_PROD-14206 branch February 19, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants