-
Notifications
You must be signed in to change notification settings - Fork 1
Lcra/refactor workspace openapi prod 14206 #858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lcra/refactor workspace openapi prod 14206 #858
Conversation
6040e8e
to
ebe6471
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some remarks ;)
GJ
run/src/integrationTest/kotlin/com/cosmotech/run/service/RunServiceIntegrationTest.kt
Show resolved
Hide resolved
...space/src/integrationTest/kotlin/com/cosmotech/workspace/service/WorkspaceServiceRBACTest.kt
Show resolved
Hide resolved
...space/src/integrationTest/kotlin/com/cosmotech/workspace/service/WorkspaceServiceRBACTest.kt
Show resolved
Hide resolved
...space/src/integrationTest/kotlin/com/cosmotech/workspace/service/WorkspaceServiceRBACTest.kt
Show resolved
Hide resolved
...space/src/integrationTest/kotlin/com/cosmotech/workspace/service/WorkspaceServiceRBACTest.kt
Show resolved
Hide resolved
workspace/src/main/kotlin/com/cosmotech/workspace/service/WorkspaceServiceImpl.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some buggy changes.
Go deeper in changes please and add some tests to be sure that it works as it should ;)
workspace/src/main/kotlin/com/cosmotech/workspace/service/WorkspaceServiceImpl.kt
Show resolved
Hide resolved
d09e282
to
a9a3700
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some work to do but the end is close! Be strong ;)
workspace/src/main/kotlin/com/cosmotech/workspace/service/WorkspaceServiceImpl.kt
Show resolved
Hide resolved
workspace/src/main/kotlin/com/cosmotech/workspace/service/WorkspaceServiceImpl.kt
Show resolved
Hide resolved
workspace/src/main/kotlin/com/cosmotech/workspace/service/WorkspaceServiceImpl.kt
Show resolved
Hide resolved
...rc/integrationTest/kotlin/com/cosmotech/workspace/service/WorkspaceServiceIntegrationTest.kt
Show resolved
Hide resolved
a9a3700
to
b50f34e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some remarks.
Almost there ;)
workspace/src/main/kotlin/com/cosmotech/workspace/service/WorkspaceServiceImpl.kt
Outdated
Show resolved
Hide resolved
workspace/src/main/kotlin/com/cosmotech/workspace/service/WorkspaceServiceImpl.kt
Outdated
Show resolved
Hide resolved
workspace/src/main/kotlin/com/cosmotech/workspace/service/WorkspaceServiceImpl.kt
Outdated
Show resolved
Hide resolved
4eeee5c
to
16b2fc2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
GG ;)
…tions in all service
…+ modified examples
cb3c768
to
9a34070
Compare
9a34070
to
741cad9
Compare
No description provided.