[PROD-13446] Solution.sdkVersion is now retrieved from the docker image #886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjoubert
force-pushed
the
sdk_version_from_docker_label
branch
from
dfed373 to
5bfee90
Compare
The field is now read only and is 'computed' at runtime from a label on
the docker image.
This requires the solution image heving been built with a SDK version
11.3.0 or newer, but it should be relatively easy to manually add the
required label ('com.cosmotech.sdk-version') with older SDK version
sjoubert
force-pushed
the
sdk_version_from_docker_label
branch
from
5bfee90 to
a56907f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The field is now read only and is 'computed' at runtime from a label on the docker image.
This requires the solution image heving been built with a SDK version 11.3.0 or newer, but it should be relatively easy to manually add the required label ('com.cosmotech.sdk-version') with older SDK version