Add CRUD on solution parameters #887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreynard-code
force-pushed
the
JREY/add_crud_on_solution_parameters
branch
from
83a8aea to
62c7b4d
Compare
lalepee
approved these changes
Mar 19, 2025
api/src/integrationTest/kotlin/com/cosmotech/api/home/solution/SolutionControllerTests.kt
Show resolved
Hide resolved
- Add /solutions/{solution_id}/parameters/POST + integration Test
- Add /solutions/{solution_id}/parameters/GET + integration Test + MvC test
- Add /solutions/{solution_id}/parameters/{parameter_id}/GET + integration Test
- Add /solutions/{solution_id}/parameters/{parameter_id}/PATCH + integration Test
- Add /solutions/{solution_id}/parameters/{parameter_id}/DELETE + integration Test + MvC test
- Define generated id, name and description on RunTemplateParameter
- Add RunTemplateParameterCreateRequest and RunTemplateParameterUpdateRequest to manage properties visibility
Some work needs to be done:
- Add /solutions/{solution_id}/parameters/POST MvC Test
- Add /solutions/{solution_id}/parameters/{parameter_id}/GET MvC Test
- Add /solutions/{solution_id}/parameters/{parameter_id}/PATCH MvC Test
- Adapt updateSolution and createSolution endpoints/tests to match with these modifications
- Add /solutions/{solution_id}/parameters/{parameter_id}/GET MvC Test
- Adapt updateSolution and createSolution endpoints/tests to match with these modifications
- Add /solutions/{solution_id}/parameters/{parameter_id}/PATCH MvC Test
… permission requirement
jreynard-code
force-pushed
the
JREY/add_crud_on_solution_parameters
branch
from
6d08516 to
ef19bf4
Compare
sjoubert
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important:
You can now update solution parameter via solution update endpoint (/organizations/{organization_id}/solutions/{solution_id}.
Now, If no parameters are specified when a solution update is requested, solution will have empty parameters property after update.
Additional endpoints:
As we allowed parameters property to be updated when a solution is updated, we added CRUD endpoints for solution parameter to manage this property easily: