feat: make run logs recuperation call argo #905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leopold-Cramer
requested review from
sjoubert,
neomatamune,
jreynard-code and
lalepee
jreynard-code
requested changes
Mar 25, 2025
run/src/main/kotlin/com/cosmotech/run/workflow/argo/RunArgoWorkflowService.kt
Show resolved
Hide resolved
run/src/main/kotlin/com/cosmotech/run/workflow/argo/RunArgoWorkflowService.kt
Outdated
Show resolved
Hide resolved
run/src/main/kotlin/com/cosmotech/run/workflow/argo/RunArgoWorkflowService.kt
Outdated
Show resolved
Hide resolved
lalepee
approved these changes
Mar 25, 2025
with the run logs removed from loki, we now have to go through argo to get the active run logs in kubernetes and the finished run logs in seaweed
Leopold-Cramer
force-pushed
the
LCRA/rebind_runLogs_to_Argo_API
branch
from
8eaf59e to
f692349
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with the run logs removed from loki, we now have to go through argo to get the active run logs in kubernetes and the finished run logs in seaweed