Lcra/update last run status #957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced `LastRunInfo` and related fields with a leaner status tracking implementation. Removed unused methods, references, and redundant logic from services and tests to improve code clarity and maintainability. Updated dependencies and enums to reflect these changes.
Updated and simplified runner service methods by removing redundant checks and throwing exceptions. Adjusted tests to align with renamed methods for improved clarity and consistency. Enhanced runner instance handling with an optional status update parameter.
Expose `getRunStatus` for broader usage and improve error handling by introducing explicit checks for runner status updates. Update tests and add the `NotStarted` state to ensure accurate status transitions in different runner scenarios.
Leopold-Cramer
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PROD-14360 Add LastRunInfo on Runner with last run Id for the runner + the last run status