fix #38 (Use of uninitialized value $5 in length at Crypt/JWT.pm line 765)

karel-m · karel-m · commit 5effd1cb2767 · 2025-01-25T16:30:00.000+01:00
diff --git a/lib/Crypt/JWT.pm b/lib/Crypt/JWT.pm
@@ -762,10 +762,11 @@ sub decode_jwt {
     croak "JWT: missing token";
   }
   elsif ($args{token} =~ /^([a-zA-Z0-9_-]+)=*\.([a-zA-Z0-9_-]*)=*\.([a-zA-Z0-9_-]*)=*(?:\.([a-zA-Z0-9_-]+)=*\.([a-zA-Z0-9_-]+)=*)?$/) {
-    if (length($5)) {
+    if (defined($5) && length($5) > 0) {
         # JWE token (5 segments)
         ($header, $payload) = Crypt::JWT::_decode_jwe($1, $2, $3, $4, $5, undef, {}, {}, %args);
-    } else {
+    }
+    else {
         # JWS token (3 segments)
         ($header, $payload) = Crypt::JWT::_decode_jws($1, $2, $3, {}, %args);
     }

Original file line number	Diff line number	Diff line change
`@@ -762,10 +762,11 @@ sub decode_jwt {`
`762`	`762`	`croak "JWT: missing token";`
`763`	`763`	`}`
`764`	`764`	`elsif ($args{token} =~ /^([a-zA-Z0-9_-]+)=\.([a-zA-Z0-9_-])=\.([a-zA-Z0-9_-])=(?:\.([a-zA-Z0-9_-]+)=\.([a-zA-Z0-9_-]+)=*)?$/) {`
`765`		`- if (length($5)) {`
	`765`	`+ if (defined($5) && length($5) > 0) {`
`766`	`766`	`# JWE token (5 segments)`
`767`	`767`	`($header, $payload) = Crypt::JWT::_decode_jwe($1, $2, $3, $4, $5, undef, {}, {}, %args);`
`768`		`- } else {`
	`768`	`+ }`
	`769`	`+ else {`
`769`	`770`	`# JWS token (3 segments)`
`770`	`771`	`($header, $payload) = Crypt::JWT::_decode_jws($1, $2, $3, {}, %args);`
`771`	`772`	`}`