Merge pull request #1 from DGerry83/feature-StarfieldShader

Starfield Shader addition

Author: DGerry83

.gitignore

@@ -364,6 +364,16 @@ FodyWeavers.xsd
 /NativePlugin/build/intermediate/CinematicShadersNative.exp
 /NativePlugin/build/intermediate
 /NativePlugin/build
-/GTAO Standalone Mod Extraction.md
 /structure.txt
 /dll_copy_config.txt
+/HipparcosData/starnamereference.txt
+/StellariumReference
+/HipparcosData/verify_names.py
+/HipparcosData/generate_starnames_json.py
+/HipparcosData/check_json.py
+/HipparcosData/check_hyg_cols.py
+/IMGUI.md
+/ReferenceNotes
+/HipparcosData/Tools/check_polaris.py
+/HipparcosData/Tools/check_polaris2.py
+/HipparcosData/Tools/add_guide_stars.py

CinematicShaders.csproj

@@ -43,16 +43,25 @@
     <Reference Include="System.Xml" />
   </ItemGroup>
   <ItemGroup>
+    <Compile Include="Core\AtmosphericScatteringData.cs" />
     <Compile Include="Core\CinematicShadersAddon.cs" />
     <Compile Include="Core\GTAOSettings.cs" />
+    <Compile Include="Core\StarCatalogInfo.cs" />
+    <Compile Include="Core\StarCatalogManager.cs" />
+    <Compile Include="Core\StarfieldPerSaveSettings.cs" />
+    <Compile Include="Core\StarfieldSettings.cs" />
     <Compile Include="Native\GTAONative.cs" />
+    <Compile Include="Native\StarfieldNative.cs" />
     <Compile Include="Properties\AssemblyInfo.cs" />
     <Compile Include="Shaders\GTAO\GTAOCompositor.cs" />
     <Compile Include="Shaders\GTAO\GTAOManager.cs" />
+    <Compile Include="Shaders\Starfield\StarfieldCompositor.cs" />
+    <Compile Include="Shaders\Starfield\StarfieldManager.cs" />
     <Compile Include="UI\CinematicShadersUIResources.cs" />
     <Compile Include="UI\CinematicShadersUIStrings.cs" />
     <Compile Include="UI\CinematicShadersWindow.cs" />
     <Compile Include="UI\Tabs\GTAOTab.cs" />
+    <Compile Include="UI\Tabs\StarfieldTab.cs" />
   </ItemGroup>
   <ItemGroup>
     <PackageReference Include="KSPBuildTools">

Core/AtmosphericScatteringData.cs

@@ -1,8 +1,10 @@
 using CinematicShaders.Native;
 using CinematicShaders.Shaders.GTAO;
+using CinematicShaders.Shaders.Starfield;
 using CinematicShaders.UI;
 using KSP.UI.Screens;
 using UnityEngine;
+using UnityEngine.SceneManagement;
 
 namespace CinematicShaders.Core
 {
@@ -29,14 +31,32 @@ void Awake()
         void Start()
         {
             GTAOSettings.Load();
+            StarfieldSettings.Load();
+            // If we're already in a game session, re-apply per-save settings to override
+            // the global settings we just loaded. This happens on scene changes within
+            // the same save (e.g., Flight -> Tracking Station -> Flight).
+            // OnGameStateLoad only fires when first loading a save, not on scene changes.
+            if (HighLogic.LoadedScene != GameScenes.MAINMENU &&
+                HighLogic.LoadedScene != GameScenes.LOADING &&
+                StarfieldPerSaveSettings.Instance != null)
+            {
+                Debug.Log("[CinematicShaders] Re-applying per-save settings after scene change");
+                StarfieldPerSaveSettings.Instance.ApplyToSettings();
+            }
+            StarCatalogManager.Initialize();  // Ensure catalog folder exists
 
-            if (HighLogic.LoadedScene != GameScenes.MAINMENU && GTAOSettings.EnableGTAO)
+            // Only auto-enable if in a playable scene (not LOADING, MAINMENU, or EDITOR)
+            if (IsPlayableScene() && (GTAOSettings.EnableGTAO || StarfieldSettings.EnableStarfield))
             {
                 Invoke(nameof(DelayedInit), 0.5f);
             }
 
             GameEvents.onGUIApplicationLauncherReady.Add(OnGUIApplicationLauncherReady);
             GameEvents.onLevelWasLoadedGUIReady.Add(OnLevelWasLoadedGUIReady);
+            
+            // Listen for game load/save events for per-save settings
+            GameEvents.onGameStateLoad.Add(OnGameStateLoad);
+            GameEvents.onGameStateSave.Add(OnGameStateSave);
 
             if (_toolbarIcon == null)
             {
@@ -56,12 +76,36 @@ private void DelayedInit()
         {
             if (GTAOSettings.EnableGTAO)
                 GTAOManager.Initialize();
+            if (StarfieldSettings.EnableStarfield)
+                StarfieldManager.Initialize();
+        }
+
+        /// <summary>
+        /// Check if current scene is a playable scene (not LOADING, MAINMENU, or EDITOR)
+        /// Starfield needs a sky camera which only exists in these scenes
+        /// </summary>
+        private bool IsPlayableScene()
+        {
+            return HighLogic.LoadedScene == GameScenes.SPACECENTER ||
+                   HighLogic.LoadedScene == GameScenes.FLIGHT ||
+                   HighLogic.LoadedScene == GameScenes.TRACKSTATION;
         }
 
         private void OnLevelWasLoadedGUIReady(GameScenes scene)
         {
             if (scene == GameScenes.MAINMENU) return;
 
+            // If coming from MAINMENU to a playable scene, reset the starfield compositor
+            // It may be in a bad state from failed initialization during game startup
+            if (StarfieldManager.IsActive)
+            {
+                Debug.Log("[CinematicShaders] Scene change from menu - resetting starfield compositor...");
+                StarfieldManager.DisableStarfield();
+            }
+
+            // Mark catalog for reload on scene change (device may have reset)
+            StarfieldSettings.InvalidateCatalogForReload();
+
             if (GTAOSettings.EnableGTAO)
             {
                 if (scene == GameScenes.EDITOR && GTAOManager.IsActive)
@@ -84,6 +128,12 @@ private void OnLevelWasLoadedGUIReady(GameScenes scene)
                     Invoke(nameof(RetryInit), 3.0f);
                 }
             }
+
+            // Initialize Starfield completely independently of GTAO
+            if (StarfieldSettings.EnableStarfield && IsPlayableScene())
+            {
+                StarfieldManager.Initialize();
+            }
         }
 
         private void RetryInit()
@@ -102,6 +152,8 @@ void OnDestroy()
 
             GameEvents.onGUIApplicationLauncherReady.Remove(OnGUIApplicationLauncherReady);
             GameEvents.onLevelWasLoadedGUIReady.Remove(OnLevelWasLoadedGUIReady);
+            GameEvents.onGameStateLoad.Remove(OnGameStateLoad);
+            GameEvents.onGameStateSave.Remove(OnGameStateSave);
 
             if (_toolbarButton != null && ApplicationLauncher.Instance != null)
             {
@@ -112,6 +164,7 @@ void OnDestroy()
             if (_mainWindow != null && _mainWindow.gameObject != null)
                 Destroy(_mainWindow.gameObject);
 
+            // Shutdown GTAO
             try
             {
                 if (GTAONative.IsLoaded)
@@ -122,9 +175,53 @@ void OnDestroy()
                 /* DLL already unloaded, ignore */
             }
 
+            // Shutdown Starfield
+            try
+            {
+                if (StarfieldNative.IsLoaded)
+                    StarfieldNative.CR_StarfieldShutdown();
+            }
+            catch (System.Exception)
+            {
+                /* DLL already unloaded, ignore */
+            }
+
             Instance = null;
         }
 
+        private void OnGameStateLoad(ConfigNode node)
+        {
+            Debug.Log("[CinematicShaders] Game state loaded - applying per-save settings");
+            
+            // Apply per-save settings from ScenarioModule if available
+            if (StarfieldPerSaveSettings.Instance != null)
+            {
+                Debug.Log("[CinematicShaders] Found StarfieldPerSaveSettings, applying...");
+                StarfieldPerSaveSettings.Instance.ApplyToSettings();
+            }
+            else
+            {
+                Debug.LogWarning("[CinematicShaders] StarfieldPerSaveSettings.Instance is null!");
+            }
+            
+            Debug.Log($"[CinematicShaders] After per-save settings: EnableStarfield={StarfieldSettings.EnableStarfield}, Catalog={StarfieldSettings.ActiveCatalogPath}");
+            
+            // Initialize starfield if enabled and we're in a playable scene
+            if (StarfieldSettings.EnableStarfield && IsPlayableScene())
+            {
+                Debug.Log("[CinematicShaders] Initializing Starfield...");
+                StarfieldManager.Initialize();
+            }
+        }
+
+        private void OnGameStateSave(ConfigNode node)
+        {
+            Debug.Log("[CinematicShaders] Game state saving - capturing per-save settings");
+            // Per-save settings are automatically saved by KSP from StarfieldPerSaveSettings.Instance
+        }
+
+
+
         private void OnGUIApplicationLauncherReady()
         {
             if (_toolbarButton != null || Instance != this) return;

Core/CinematicShadersAddon.cs

@@ -0,0 +1,68 @@
+using System;
+
+namespace CinematicShaders.Core
+{
+    /// <summary>
+    /// Metadata for a star catalog file
+    /// </summary>
+    public class StarCatalogInfo
+    {
+        public string FilePath { get; set; }
+        public string DisplayName { get; set; }
+        public bool IsReadOnly { get; set; }
+        public DateTime CreatedDate { get; set; }
+        public int StarCount { get; set; }
+        public int HeroCount { get; set; }
+        public int GenerationSeed { get; set; }
+        
+        // Catalog type (Version 6+)
+        public bool IsProcedural { get; set; }
+        
+        // Generation parameters stored for "Clone & Modify" functionality
+        // Only meaningful for procedural catalogs
+        public float MinMagnitude { get; set; }
+        public float MaxMagnitude { get; set; }
+        public float MagnitudeBias { get; set; }
+        public float Clustering { get; set; }
+        public float PopulationBias { get; set; }
+        public float MainSequenceStrength { get; set; }
+        public float RedGiantFrequency { get; set; }
+        public float GalacticFlatness { get; set; }
+        
+        // Catalog rotation (Version 5+) - orientation of starfield in sky
+        // Available for both procedural and intentional catalogs
+        public float RotationX { get; set; }
+        public float RotationY { get; set; }
+        public float RotationZ { get; set; }
+        
+        /// <summary>
+        /// Returns the display name, or filename if no custom name set
+        /// </summary>
+        public string GetDisplayName()
+        {
+            if (!string.IsNullOrEmpty(DisplayName))
+                return DisplayName;
+            
+            // Extract filename without extension
+            try
+            {
+                return System.IO.Path.GetFileNameWithoutExtension(FilePath);
+            }
+            catch
+            {
+                return FilePath;
+            }
+        }
+        
+        /// <summary>
+        /// Returns string for dropdown with read-only indicator
+        /// </summary>
+        public string GetDropdownLabel()
+        {
+            string name = GetDisplayName();
+            if (IsReadOnly)
+                return "🔒 " + name;
+            return name;
+        }
+    }
+}