Merge pull request #1826 from DGtal-team/TestAffine

testAffineBasis fix

Author: dcoeurjo

ChangeLog.md

@@ -46,7 +46,8 @@ git remote set-head origin -a
   - Fix issue [#1797](https://github.com/DGtal-team/DGtal/pull/1797), assertions raised in testCellGeometry and testDigitalConvexity because of improper digital space extent (Jacques-Olivier Lachaud, [#1801](https://github.com/DGtal-team/DGtal/pull/1801))
   - QuickHull could sometimes output that its output was not full dimensional since the computation of affine dimension was randomized. Now QuickHull relies on an exact computation of affine dimension (Jacques-Olivier Lachaud, [#1803](https://github.com/DGtal-team/DGtal/pull/1803))
   - Silencing a warning in the Naive3DDSSComputer.ih file. (David Coeurjolly, [#1815](https://github.com/DGtal-team/DGtal/pull/1815))
-
+  - Fix issue in `testAffineBasis` that may produce errors for some compilers (David Coeurjolly, [#1826](https://github.com/DGtal-team/DGtal/pull/1826))
+  
 - *Build*
   - Version is now extracted from the `VERSION` file for CMake and Python builds (Bastien Doignies, [#1810](https://github.com/DGtal-team/DGtal/pull/1810))
   - Eigen is now properly fetched when DGTAL_ITK_WITH_EIGEN is set (Bastien Doignies, [#1818](https://github.com/DGtal-team/DGtal/pull/1818))

tests/geometry/tools/testAffineBasis.cpp

@@ -230,7 +230,7 @@ SCENARIO( "AffineBasis< Point4i > unit tests", "[affine_basis][4i]" )
       for ( auto p : X )
         {
           const auto [d, lambda, rem ] = B.decompose( p );
-          nb_ok += ( rem == Point::zero ) ? : 1;
+          nb_ok += ( rem == Point::zero ) ?  1:0;
           if ( rem != Point::zero )
             std::cout << "p=" << p << " d=" << d
                       << " lambda=" << lambda << " rem=" << rem << "\n";
@@ -245,7 +245,7 @@ SCENARIO( "AffineBasis< Point4i > unit tests", "[affine_basis][4i]" )
           const auto p = y + B.first;
           const auto [d, lambda, rem ] = B.decompose( p );
           auto q = B.recompose( d, lambda, rem );
-          nb_ok += ( p == q ) ? : 1;
+          nb_ok += ( p == q ) ? 1: 0;
           if ( p != q )
             std::cout << "p=" << p << " d=" << d
                       << " lambda=" << lambda << " rem=" << rem
@@ -428,7 +428,7 @@ SCENARIO( "AffineBasis< Z10 > LLL tests", "[affine_basis][10d][LLL]" )
       unsigned int nbok = 0;
       for ( auto i = 0; i < V.size(); i++ )
       {
-        nbok += V[ i ].norm1() == 1 ? : 0;
+        nbok += (V[ i ].norm1() == 1) ? 1 : 0;
         nb++;
       }
       CAPTURE( L.basis() );