Update polyscope viewer with an error if DGTAL_WITH_POLYSCOPE_VIEWER is missing#1814
Merged
Update polyscope viewer with an error if DGTAL_WITH_POLYSCOPE_VIEWER is missing#1814
Conversation
…nabled, polyscope examples will be built
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request consolidates Polyscope viewer configuration by replacing the DGTAL_BUILD_POLYSCOPE_EXAMPLES option with DGTAL_WITH_POLYSCOPE_VIEWER and renaming the internal DGTAL_WITH_POLYSCOPE flag to DGTAL_WITH_POLYSCOPE_VIEWER throughout the codebase.
Key changes:
- Unified the Polyscope configuration to use a single
DGTAL_WITH_POLYSCOPE_VIEWERflag - Removed the separate
DGTAL_BUILD_POLYSCOPE_EXAMPLESoption, now examples are automatically built when the viewer is enabled - Added a compile-time error guard in PolyscopeViewer.h to catch missing flag configuration
- Fixed polyscope initialization ordering in example files to initialize before registering objects
Reviewed Changes
Copilot reviewed 32 out of 32 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/shapes/CMakeLists.txt | Updated conditional compilation flag from DGTAL_WITH_POLYSCOPE to DGTAL_WITH_POLYSCOPE_VIEWER |
| tests/io/viewers/CMakeLists.txt | Updated conditional compilation flag from DGTAL_WITH_POLYSCOPE to DGTAL_WITH_POLYSCOPE_VIEWER |
| tests/geometry/tools/CMakeLists.txt | Updated conditional compilation flag from DGTAL_WITH_POLYSCOPE to DGTAL_WITH_POLYSCOPE_VIEWER |
| tests/geometry/surfaces/testSphericalHoughNormalVectorEstimator.cpp | Updated preprocessor directive from DGTAL_WITH_POLYSCOPE to DGTAL_WITH_POLYSCOPE_VIEWER |
| tests/geometry/surfaces/CMakeLists.txt | Updated conditional compilation flag from DGTAL_WITH_POLYSCOPE to DGTAL_WITH_POLYSCOPE_VIEWER |
| src/DGtal/io/viewers/PolyscopeViewer.h | Added compile-time error guard for missing DGTAL_WITH_POLYSCOPE_VIEWER flag |
| src/DGtal/io/doc/moduleDisplay3D.dox | Added warning about enabling Polyscope at cmake step |
| src/DGtal/io/doc/migratingViewer3D.dox | Added warning about enabling Polyscope at cmake step |
| src/DGtal/dec/doc/modulePolygonalCalculus.dox | Updated build instructions to reference DGTAL_WITH_POLYSCOPE_VIEWER instead of DGTAL_BUILD_POLYSCOPE_EXAMPLES |
| src/DGtal/base/Common.h | Updated conditional compilation flag from DGTAL_WITH_POLYSCOPE to DGTAL_WITH_POLYSCOPE_VIEWER |
| examples/tutorial-examples/CMakeLists.txt | Updated conditional compilation flag from DGTAL_WITH_POLYSCOPE to DGTAL_WITH_POLYSCOPE_VIEWER |
| examples/topology/CMakeLists.txt | Updated conditional compilation flag from DGTAL_WITH_POLYSCOPE to DGTAL_WITH_POLYSCOPE_VIEWER |
| examples/io/external-viewers/polyscope/dgtalCalculus-single.cpp | Fixed polyscope initialization order to call polyscope::init() before registering objects |
| examples/io/external-viewers/polyscope/dgtalCalculus-poisson.cpp | Fixed polyscope initialization order to call polyscope::init() before registering objects |
| examples/io/external-viewers/polyscope/CMakeLists.txt | Removed obsolete DGTAL_BUILD_POLYSCOPE_EXAMPLES check and polyscope target verification |
| examples/io/CMakeLists.txt | Updated conditional compilation flag from DGTAL_WITH_POLYSCOPE to DGTAL_WITH_POLYSCOPE_VIEWER |
| examples/graph/CMakeLists.txt | Updated conditional compilation flag from DGTAL_WITH_POLYSCOPE to DGTAL_WITH_POLYSCOPE_VIEWER |
| examples/geometry/volumes/distance/CMakeLists.txt | Updated conditional compilation flag from DGTAL_WITH_POLYSCOPE to DGTAL_WITH_POLYSCOPE_VIEWER |
| examples/geometry/volumes/CMakeLists.txt | Updated conditional compilation flag from DGTAL_WITH_POLYSCOPE to DGTAL_WITH_POLYSCOPE_VIEWER |
| examples/geometry/surfaces/CMakeLists.txt | Updated conditional compilation flag from DGTAL_WITH_POLYSCOPE to DGTAL_WITH_POLYSCOPE_VIEWER |
| examples/geometry/curves/exampleTrofoliKnot.cpp | Updated preprocessor directive and removed template parameters from PolyscopeViewer instantiation |
| examples/geometry/curves/exampleParamCurve3dDigitizationTransformationDecorator.cpp | Updated preprocessor directive from DGTAL_WITH_POLYSCOPE to DGTAL_WITH_POLYSCOPE_VIEWER |
| examples/geometry/curves/exampleParamCurve3dDigitization.cpp | Updated preprocessor directive from DGTAL_WITH_POLYSCOPE to DGTAL_WITH_POLYSCOPE_VIEWER |
| examples/geometry/curves/exampleGridCurve3d.cpp | Updated preprocessor directive from DGTAL_WITH_POLYSCOPE to DGTAL_WITH_POLYSCOPE_VIEWER |
| examples/geometry/curves/exampleArithDSS3d.cpp | Updated preprocessor directives from DGTAL_WITH_POLYSCOPE to DGTAL_WITH_POLYSCOPE_VIEWER |
| examples/geometry/curves/CMakeLists.txt | Updated conditional compilation flag from DGTAL_WITH_POLYSCOPE to DGTAL_WITH_POLYSCOPE_VIEWER |
| examples/doc-examples/CMakeLists.txt | Updated conditional compilation flag from DGTAL_WITH_POLYSCOPE to DGTAL_WITH_POLYSCOPE_VIEWER |
| cmake/Install.cmake | Fixed message output to use correct variable name for consistency |
| cmake/CheckDGtalOptionalDependencies.cmake | Consolidated Polyscope configuration logic to use single DGTAL_WITH_POLYSCOPE_VIEWER flag |
| cmake/BuildExamples.cmake | Removed DGTAL_BUILD_POLYSCOPE_EXAMPLES option and updated messaging to reference DGTAL_WITH_POLYSCOPE_VIEWER |
| ChangeLog.md | Added documentation for changes related to DGTAL_BUILD_POLYSCOPE_EXAMPLES removal and flag renaming |
| .github/actions/dgtal-config/action.yml | Removed DGTAL_BUILD_POLYSCOPE_EXAMPLES from GitHub Actions configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Member
Author
|
Self-merging |
Member
|
that looks fine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Checklist