Skip to content

Fix install#1815

Merged
dcoeurjo merged 24 commits intoDGtal-team:mainfrom
BDoignies:FixInstall
Nov 6, 2025
Merged

Fix install#1815
dcoeurjo merged 24 commits intoDGtal-team:mainfrom
BDoignies:FixInstall

Conversation

@BDoignies
Copy link
Copy Markdown
Contributor

PR Description

Fixing some install commands for polyscope dependancies. It also adds a step to test that system wide installation works and can be linked properly using find_package.

@dcoeurjo The test is located inside tests/projects as I couldn't think of a better name. If you have one, please let me know.

Checklist

  • Unit-test of your feature with Catch.
  • [N/A] Doxygen documentation of the code completed (classes, methods, types, members...)
  • [N/A] Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug mode.
  • All continuous integration tests pass (Github Actions)

@dcoeurjo
Copy link
Copy Markdown
Member

thanks a lot ! tests/project is fine to me.

@BDoignies
Copy link
Copy Markdown
Contributor Author

@dcoeurjo Should be good now. I do not exactly know what to do with codacy reports.

Should we add some useless code to remove the warnings? Any ideas on other things we should try to compile (especially for optional dependencies)?

@dcoeurjo
Copy link
Copy Markdown
Member

dcoeurjo commented Nov 4, 2025

Thanks @BDoignies I will have a look.
Regarding Codacy, I am inclined to remove this check... it is rarely informative for a so big C++ project...

Copy link
Copy Markdown
Member

@dcoeurjo dcoeurjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, just a few questions.

Comment thread cmake/DGtalConfig.cmake.in
Comment thread cmake/deps/polyscope.cmake
@dcoeurjo dcoeurjo self-requested a review November 5, 2025 14:05
Copy link
Copy Markdown
Member

@dcoeurjo dcoeurjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. Thx again

@dcoeurjo dcoeurjo merged commit 8e8fce3 into DGtal-team:main Nov 6, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants