Merged
Conversation
Member
|
thanks a lot ! |
Contributor
Author
|
@dcoeurjo Should be good now. I do not exactly know what to do with codacy reports. Should we add some useless code to remove the warnings? Any ideas on other things we should try to compile (especially for optional dependencies)? |
Member
|
Thanks @BDoignies I will have a look. |
dcoeurjo
reviewed
Nov 5, 2025
Member
dcoeurjo
left a comment
There was a problem hiding this comment.
Thanks for the PR, just a few questions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Fixing some install commands for polyscope dependancies. It also adds a step to test that system wide installation works and can be linked properly using find_package.
@dcoeurjo The test is located inside tests/projects as I couldn't think of a better name. If you have one, please let me know.
Checklist