Skip to content

Commit ee0a13e

Browse files
committed
fix: lodash depedency for autocomplete
1 parent 34825de commit ee0a13e

File tree

4 files changed

+24
-4
lines changed

4 files changed

+24
-4
lines changed

package-lock.json

+14
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+2
Original file line numberDiff line numberDiff line change
@@ -74,11 +74,13 @@
7474
"@testing-library/react": "^12.0.0",
7575
"@testing-library/user-event": "^13.1.9",
7676
"@types/jest": "^26.0.24",
77+
"@types/lodash": "^4.14.172",
7778
"@types/node": "^16.0.1",
7879
"@types/react": "^17.0.14",
7980
"@types/react-dom": "^17.0.9",
8081
"@types/styled-components": "^5.1.11",
8182
"babel-loader": "^8.2.2",
83+
"lodash": "^4.17.21",
8284
"prop-types": "^15.7.2",
8385
"react": "^17.0.2",
8486
"react-dom": "^17.0.2",

rollup.config.js

+5-1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,9 @@ export default [
1313
dir: './',
1414
entryFileNames: 'lib/cjs/index.js',
1515
format: 'cjs',
16+
globals:{
17+
'lodash': '_'
18+
}
1619
},
1720
plugins: [
1821
del({ targets: 'lib/*' }),
@@ -26,6 +29,7 @@ export default [
2629
peerDepsExternal(),
2730
resolve(),
2831
svgr()
29-
]
32+
],
33+
external: ['lodash']
3034
},
3135
]

src/components/Autocomplete.tsx

+3-3
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import {
1111
TextFieldProps,
1212
} from "@material-ui/core";
1313
import styled from "styled-components";
14-
import { debounce } from "lodash";
14+
import _ from "lodash";
1515
import { useRef } from "react";
1616

1717
const BootstrapTextField = styled(TextField)`
@@ -110,7 +110,7 @@ function AutocompleteInner<
110110
);
111111

112112
var debouncedSearch = useRef(
113-
debounce(search, waitingTime, {
113+
_.debounce(search, waitingTime, {
114114
leading: true,
115115
})
116116
);
@@ -135,7 +135,7 @@ function AutocompleteInner<
135135
setLoading(false);
136136
if (firstloading) {
137137
setFirstLoading(false);
138-
debouncedSearch.current = debounce(search, waitingTime, {
138+
debouncedSearch.current = _.debounce(search, waitingTime, {
139139
leading: false,
140140
});
141141
}

0 commit comments

Comments
 (0)