You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Request the whole editor configuration and just read the values we care about
Request only the values we care about individually (editor.formatOnSave, editor.codeActionsOnSave etc.)
The first one results in all of the editor settings be included in the payload (once for global, once for each workspace folder) which isn't terrible, but also means this shows up in instrumentation logs (where it didn't before).
The second seems better, however it currently fails because we have middleware to set enableSnippets that assumes that the only configuration we ever provide is an object (eg. the dart section). When requesting editor.formatOnSave, we'll try to set a field named enableSnippets on a boolean and fail.
We should fix the middleware to be more tolerant of other settings being added in future.
The text was updated successfully, but these errors were encountered:
For dart-lang/sdk#60259, we have two options:
editor
configuration and just read the values we care abouteditor.formatOnSave
,editor.codeActionsOnSave
etc.)The first one results in all of the editor settings be included in the payload (once for global, once for each workspace folder) which isn't terrible, but also means this shows up in instrumentation logs (where it didn't before).
The second seems better, however it currently fails because we have middleware to set
enableSnippets
that assumes that the only configuration we ever provide is anobject
(eg. thedart
section). When requestingeditor.formatOnSave
, we'll try to set a field namedenableSnippets
on a boolean and fail.We should fix the middleware to be more tolerant of other settings being added in future.
The text was updated successfully, but these errors were encountered: