🐛 do not calculate resource duration if page was in frozen state during resource duration

Author: thomas-lebeau

packages/rum-core/src/domain/resource/resourceCollection.ts

@@ -54,13 +54,13 @@ export function startResourceCollection(
   }).subscribe((entries) => {
     for (const entry of entries) {
       if (!isResourceEntryRequestType(entry)) {
-        handleResource(() => processResourceEntry(entry, configuration))
+        handleResource(() => processResourceEntry(entry, configuration, pageStateHistory))
       }
     }
   })
 
   retrieveInitialDocumentResourceTimingImpl(configuration, (timing) => {
-    handleResource(() => processResourceEntry(timing, configuration))
+    handleResource(() => processResourceEntry(timing, configuration, pageStateHistory))
   })
 
   function handleResource(computeRawEvent: () => RawRumEventCollectedData<RawRumResourceEvent> | undefined) {
@@ -91,11 +91,15 @@ function processRequest(
     return
   }
 
+  const duration = computeRequestDuration(pageStateHistory, startClocks, request.duration)
+
   const type = request.type === RequestType.XHR ? ResourceType.XHR : ResourceType.FETCH
 
-  const correspondingTimingOverrides = matchingTiming ? computeResourceEntryMetrics(matchingTiming) : undefined
+  console.log('matchingTiming', matchingTiming)
 
-  const duration = computeRequestDuration(pageStateHistory, startClocks, request.duration)
+  const correspondingTimingOverrides = matchingTiming
+    ? computeResourceEntryMetrics(matchingTiming, pageStateHistory)
+    : undefined
 
   const resourceEvent = combine(
     {
@@ -137,7 +141,8 @@ function processRequest(
 
 function processResourceEntry(
   entry: RumPerformanceResourceTiming,
-  configuration: RumConfiguration
+  configuration: RumConfiguration,
+  pageStateHistory: PageStateHistory
 ): RawRumEventCollectedData<RawRumResourceEvent> | undefined {
   const startClocks = relativeToClocks(entry.startTime)
   const tracingInfo = computeResourceEntryTracingInfo(entry, configuration)
@@ -146,7 +151,7 @@ function processResourceEntry(
   }
 
   const type = computeResourceEntryType(entry)
-  const entryMetrics = computeResourceEntryMetrics(entry)
+  const entryMetrics = computeResourceEntryMetrics(entry, pageStateHistory)
 
   const resourceEvent = combine(
     {
@@ -176,14 +181,23 @@ function processResourceEntry(
   }
 }
 
-function computeResourceEntryMetrics(entry: RumPerformanceResourceTiming) {
+function computeResourceEntryMetrics(entry: RumPerformanceResourceTiming, pageStateHistory: PageStateHistory) {
   const { renderBlockingStatus } = entry
+  if (!pageStateHistory.wasInPageStateDuringPeriod(PageState.FROZEN, entry.startTime, entry.duration)) {
+    return {
+      resource: {
+        duration: computeResourceEntryDuration(entry),
+        render_blocking_status: renderBlockingStatus,
+        ...computeResourceEntrySize(entry),
+        ...computeResourceEntryDetails(entry),
+      },
+    }
+  }
+
   return {
     resource: {
-      duration: computeResourceEntryDuration(entry),
       render_blocking_status: renderBlockingStatus,
       ...computeResourceEntrySize(entry),
-      ...computeResourceEntryDetails(entry),
     },
   }
 }
@@ -216,16 +230,16 @@ function computeResourceEntryTracingInfo(entry: RumPerformanceResourceTiming, co
   }
 }
 
-function computeRequestDuration(pageStateHistory: PageStateHistory, startClocks: ClocksState, duration: Duration) {
-  return !pageStateHistory.wasInPageStateDuringPeriod(PageState.FROZEN, startClocks.relative, duration)
-    ? toServerDuration(duration)
-    : undefined
-}
-
 /**
  * The status is 0 for cross-origin resources without CORS headers, so the status is meaningless, and we shouldn't report it
  * https://developer.mozilla.org/en-US/docs/Web/API/PerformanceResourceTiming/responseStatus#cross-origin_response_status_codes
  */
 function discardZeroStatus(statusCode: number | undefined): number | undefined {
   return statusCode === 0 ? undefined : statusCode
 }
+
+function computeRequestDuration(pageStateHistory: PageStateHistory, startClocks: ClocksState, duration: Duration) {
+  return !pageStateHistory.wasInPageStateDuringPeriod(PageState.FROZEN, startClocks.relative, duration)
+    ? toServerDuration(duration)
+    : undefined
+}