✅ test performance timing matching

Author: thomas-lebeau

packages/rum-core/src/domain/resource/resourceCollection.spec.ts

@@ -58,7 +58,11 @@ describe('resourceCollection', () => {
   beforeEach(() => {
     ;({ notifyPerformanceEntries } = mockPerformanceObserver())
     globalPerformanceObjectMock = mockGlobalPerformanceBuffer()
-    globalPerformanceObjectMock.addPerformanceEntry(createPerformanceEntry(RumPerformanceEntryType.RESOURCE))
+    globalPerformanceObjectMock.addPerformanceEntry(
+      createPerformanceEntry(RumPerformanceEntryType.RESOURCE, {
+        responseStart: 250 as RelativeTime,
+      })
+    )
     wasInPageStateDuringPeriodSpy = spyOn(pageStateHistory, 'wasInPageStateDuringPeriod')
   })
 
@@ -110,29 +114,30 @@ describe('resourceCollection', () => {
     lifeCycle.notify(
       LifeCycleEventType.REQUEST_COMPLETED,
       createCompletedRequest({
-        duration: 100 as Duration,
-        method: 'GET',
-        startClocks: { relative: 1234 as RelativeTime, timeStamp: 123456789 as TimeStamp },
-        status: 200,
-        type: RequestType.XHR,
-        url: 'https://resource.com/valid',
         xhr,
         isAborted: false,
       })
     )
 
-    expect(rawRumEvents[0].startTime).toBe(1234 as RelativeTime)
+    expect(rawRumEvents[0].startTime).toBe(200 as RelativeTime)
     expect(rawRumEvents[0].rawRumEvent).toEqual({
       date: jasmine.any(Number),
       resource: {
         id: jasmine.any(String),
         duration: (100 * 1e6) as ServerDuration,
         method: 'GET',
         status_code: 200,
-        delivery_type: undefined,
-        protocol: undefined,
+        delivery_type: 'cache',
+        protocol: 'HTTP/1.0',
         type: ResourceType.XHR,
         url: 'https://resource.com/valid',
+        render_blocking_status: 'non-blocking',
+        size: 1000,
+        encoded_body_size: 500,
+        decoded_body_size: 1000,
+        transfer_size: 500,
+        download: Object({ duration: 50_000_000, start: 50_000_000 }),
+        first_byte: Object({ duration: 50_000_000, start: 0 }),
       },
       type: RumEventType.RESOURCE,
       _dd: {
@@ -141,7 +146,7 @@ describe('resourceCollection', () => {
     })
     expect(rawRumEvents[0].domainContext).toEqual({
       xhr,
-      performanceEntry: undefined,
+      performanceEntry: jasmine.any(Object),
       response: undefined,
       requestInput: undefined,
       requestInit: undefined,
@@ -202,16 +207,36 @@ describe('resourceCollection', () => {
     })
   })
 
-  it('should not have a duration if a frozen state happens during the request and no performance entry matches', () => {
+  it('should not have any duration properties if a frozen state happens during the request and no performance entry matches', () => {
     setupResourceCollection()
     const mockXHR = createCompletedRequest()
 
     wasInPageStateDuringPeriodSpy.and.returnValue(true)
 
     lifeCycle.notify(LifeCycleEventType.REQUEST_COMPLETED, mockXHR)
 
-    const rawRumResourceEventFetch = rawRumEvents[0].rawRumEvent as RawRumResourceEvent
-    expect(rawRumResourceEventFetch.resource.duration).toBeUndefined()
+    expect(rawRumEvents[0].rawRumEvent).toEqual({
+      date: jasmine.any(Number),
+      resource: {
+        id: jasmine.any(String),
+        duration: undefined,
+        method: 'GET',
+        status_code: 200,
+        delivery_type: 'cache',
+        protocol: 'HTTP/1.0',
+        type: ResourceType.XHR,
+        url: 'https://resource.com/valid',
+        render_blocking_status: 'non-blocking',
+        size: 1000,
+        encoded_body_size: 500,
+        decoded_body_size: 1000,
+        transfer_size: 500,
+      },
+      type: RumEventType.RESOURCE,
+      _dd: {
+        discarded: false,
+      },
+    })
   })
 
   it('should create resource from completed fetch request', () => {
@@ -220,10 +245,6 @@ describe('resourceCollection', () => {
     lifeCycle.notify(
       LifeCycleEventType.REQUEST_COMPLETED,
       createCompletedRequest({
-        duration: 100 as Duration,
-        method: 'GET',
-        startClocks: { relative: 1234 as RelativeTime, timeStamp: 123456789 as TimeStamp },
-        status: 200,
         type: RequestType.FETCH,
         url: 'https://resource.com/valid',
         response,
@@ -233,26 +254,33 @@ describe('resourceCollection', () => {
       })
     )
 
-    expect(rawRumEvents[0].startTime).toBe(1234 as RelativeTime)
+    expect(rawRumEvents[0].startTime).toBe(200 as RelativeTime)
     expect(rawRumEvents[0].rawRumEvent).toEqual({
       date: jasmine.any(Number),
       resource: {
         id: jasmine.any(String),
         duration: (100 * 1e6) as ServerDuration,
         method: 'GET',
         status_code: 200,
-        delivery_type: undefined,
-        protocol: undefined,
+        delivery_type: 'cache',
+        protocol: 'HTTP/1.0',
         type: ResourceType.FETCH,
         url: 'https://resource.com/valid',
+        render_blocking_status: 'non-blocking',
+        size: 1000,
+        encoded_body_size: 500,
+        decoded_body_size: 1000,
+        transfer_size: 500,
+        download: Object({ duration: 50_000_000, start: 50_000_000 }),
+        first_byte: Object({ duration: 50_000_000, start: 0 }),
       },
       type: RumEventType.RESOURCE,
       _dd: {
         discarded: false,
       },
     })
     expect(rawRumEvents[0].domainContext).toEqual({
-      performanceEntry: undefined,
+      performanceEntry: jasmine.any(Object),
       xhr: undefined,
       response,
       requestInput: 'https://resource.com/valid',