Skip to content

Vickenty/das ppl #39049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Vickenty/das ppl #39049

wants to merge 9 commits into from

Conversation

vickenty
Copy link
Contributor

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

lukesteensen and others added 9 commits July 8, 2025 21:18
This refactors the series serialization logic to reify the pattern repeated by
MRF, local autoscaling, etc, where we build variations of the payload based on
various filters for various destinations. This makes it much cleaner to add
additional such pipelines in the future.

Signed-off-by: Luke Steensen <[email protected]>
Signed-off-by: Luke Steensen <[email protected]>
Instead of blocking time sampler while we flush and serialize the
metrics, move closed metrics buckets out of the time sampler maps and
run flush in background, unblocking time sampler to process more
metrics.
@github-actions github-actions bot added long review PR is complex, plan time to review it team/agent-metric-pipelines labels Jul 18, 2025
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 516bfced-6d6f-40e7-a4d3-547b7af3a9f6

Baseline: bae87f6
Comparison: b859948
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +0.12 [-3.01, +3.25] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.56 [+0.52, +0.60] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.52 [-0.32, +1.37] 1 Logs
docker_containers_cpu % cpu utilization +0.12 [-3.01, +3.25] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.06 [-0.60, +0.71] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.06 [-0.56, +0.68] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.01 [-0.01, +0.03] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.27, +0.28] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.00 [-0.60, +0.59] 1 Logs
ddot_metrics memory utilization -0.06 [-0.19, +0.06] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.10 [-0.66, +0.47] 1 Logs
ddot_logs memory utilization -0.10 [-0.19, -0.01] 1 Logs
quality_gate_idle_all_features memory utilization -0.10 [-0.16, -0.04] 1 Logs bounds checks dashboard
otlp_ingest_logs memory utilization -0.16 [-0.28, -0.04] 1 Logs
file_tree memory utilization -0.17 [-0.21, -0.13] 1 Logs
otlp_ingest_metrics memory utilization -0.25 [-0.39, -0.10] 1 Logs
docker_containers_memory memory utilization -0.37 [-0.44, -0.31] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.42 [-0.49, -0.36] 1 Logs
quality_gate_idle memory utilization -0.52 [-0.55, -0.48] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -0.82 [-3.57, +1.93] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
long review PR is complex, plan time to review it team/agent-metric-pipelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants