Skip to content

Commit e53d667

Browse files
maxepmaxep
committed
RUM-9747 Trace Additional Context
1 parent eb6381b commit e53d667

File tree

7 files changed

+52
-101
lines changed

7 files changed

+52
-101
lines changed

‎Datadog/Datadog.xcodeproj/project.pbxproj

Lines changed: 16 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1056,10 +1056,6 @@
10561056
D22789372D64A0D7007E9DB0 /* UploadQualityMetric.swift in Sources */ = {isa = PBXBuildFile; fileRef = D22789352D64A0D3007E9DB0 /* UploadQualityMetric.swift */; };
10571057
D227A0A42C7622EA00C83324 /* BenchmarkProfiler.swift in Sources */ = {isa = PBXBuildFile; fileRef = D227A0A32C7622EA00C83324 /* BenchmarkProfiler.swift */; };
10581058
D227A0A52C7622EA00C83324 /* BenchmarkProfiler.swift in Sources */ = {isa = PBXBuildFile; fileRef = D227A0A32C7622EA00C83324 /* BenchmarkProfiler.swift */; };
1059-
D22C5BC82A98A0B20024CC1F /* Baggages.swift in Sources */ = {isa = PBXBuildFile; fileRef = D22C5BC52A989D130024CC1F /* Baggages.swift */; };
1060-
D22C5BC92A98A0B30024CC1F /* Baggages.swift in Sources */ = {isa = PBXBuildFile; fileRef = D22C5BC52A989D130024CC1F /* Baggages.swift */; };
1061-
D22C5BCB2A98A5400024CC1F /* Baggages.swift in Sources */ = {isa = PBXBuildFile; fileRef = D22C5BCA2A98A5400024CC1F /* Baggages.swift */; };
1062-
D22C5BCC2A98A5400024CC1F /* Baggages.swift in Sources */ = {isa = PBXBuildFile; fileRef = D22C5BCA2A98A5400024CC1F /* Baggages.swift */; };
10631059
D22C5BD02A98A6660024CC1F /* Baggages.swift in Sources */ = {isa = PBXBuildFile; fileRef = D22C5BCD2A98A65D0024CC1F /* Baggages.swift */; };
10641060
D22F06D729DAFD500026CC3C /* FixedWidthInteger+Convenience.swift in Sources */ = {isa = PBXBuildFile; fileRef = D22F06D529DAFD500026CC3C /* FixedWidthInteger+Convenience.swift */; };
10651061
D22F06D829DAFD500026CC3C /* FixedWidthInteger+Convenience.swift in Sources */ = {isa = PBXBuildFile; fileRef = D22F06D529DAFD500026CC3C /* FixedWidthInteger+Convenience.swift */; };
@@ -1479,6 +1475,8 @@
14791475
D2BEEDB92B3360F50065F3AC /* URLSessionTaskDelegateSwizzlerTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = D2BEEDB72B3360F50065F3AC /* URLSessionTaskDelegateSwizzlerTests.swift */; };
14801476
D2BEEDBA2B33638F0065F3AC /* NetworkInstrumentationSwizzler.swift in Sources */ = {isa = PBXBuildFile; fileRef = D2181A8A2B0500BB00A518C0 /* NetworkInstrumentationSwizzler.swift */; };
14811477
D2BEEDBB2B3363900065F3AC /* NetworkInstrumentationSwizzler.swift in Sources */ = {isa = PBXBuildFile; fileRef = D2181A8A2B0500BB00A518C0 /* NetworkInstrumentationSwizzler.swift */; };
1478+
D2C179E12DD2388800556F68 /* SpanCoreContext.swift in Sources */ = {isa = PBXBuildFile; fileRef = D2C179E02DD2388800556F68 /* SpanCoreContext.swift */; };
1479+
D2C179E22DD2388800556F68 /* SpanCoreContext.swift in Sources */ = {isa = PBXBuildFile; fileRef = D2C179E02DD2388800556F68 /* SpanCoreContext.swift */; };
14821480
D2C1A4FA29C4C4CB00946C31 /* SpanSanitizer.swift in Sources */ = {isa = PBXBuildFile; fileRef = 61122ECD25B1B74500F9C7F5 /* SpanSanitizer.swift */; };
14831481
D2C1A4FB29C4C4CB00946C31 /* MessageReceivers.swift in Sources */ = {isa = PBXBuildFile; fileRef = D2546C0A29AF56270054E00B /* MessageReceivers.swift */; };
14841482
D2C1A4FC29C4C4CB00946C31 /* RequestBuilder.swift in Sources */ = {isa = PBXBuildFile; fileRef = D2546C0729AF55E90054E00B /* RequestBuilder.swift */; };
@@ -3064,8 +3062,6 @@
30643062
D22789352D64A0D3007E9DB0 /* UploadQualityMetric.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = UploadQualityMetric.swift; sourceTree = "<group>"; };
30653063
D227A0A32C7622EA00C83324 /* BenchmarkProfiler.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = BenchmarkProfiler.swift; sourceTree = "<group>"; };
30663064
D22C1F5B271484B400922024 /* LogEventMapper.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = LogEventMapper.swift; sourceTree = "<group>"; };
3067-
D22C5BC52A989D130024CC1F /* Baggages.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = Baggages.swift; sourceTree = "<group>"; };
3068-
D22C5BCA2A98A5400024CC1F /* Baggages.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = Baggages.swift; sourceTree = "<group>"; };
30693065
D22C5BCD2A98A65D0024CC1F /* Baggages.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = Baggages.swift; sourceTree = "<group>"; };
30703066
D22F06D529DAFD500026CC3C /* FixedWidthInteger+Convenience.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = "FixedWidthInteger+Convenience.swift"; sourceTree = "<group>"; };
30713067
D22F06D629DAFD500026CC3C /* TimeInterval+Convenience.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = "TimeInterval+Convenience.swift"; sourceTree = "<group>"; };
@@ -3126,6 +3122,7 @@
31263122
D249859F2728042200B4F72D /* SwiftUIViewModifier.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = SwiftUIViewModifier.swift; sourceTree = "<group>"; };
31273123
D24985A12728048B00B4F72D /* SwiftUIViewHandler.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = SwiftUIViewHandler.swift; sourceTree = "<group>"; };
31283124
D24C9C3E29A79772002057CF /* Logger.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = Logger.swift; sourceTree = "<group>"; };
3125+
D24EC3D22DCE4720007A7E8F /* SpanCoreContext.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SpanCoreContext.swift; sourceTree = "<group>"; };
31293126
D253EE952B988CA90010B589 /* ViewCache.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ViewCache.swift; sourceTree = "<group>"; };
31303127
D253EE982B98B3690010B589 /* ViewCacheTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ViewCacheTests.swift; sourceTree = "<group>"; };
31313128
D2546BF029AF4F550054E00B /* DatadogTracer.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = DatadogTracer.swift; sourceTree = "<group>"; };
@@ -3219,6 +3216,7 @@
32193216
D2BEEDB12B335DA90065F3AC /* URLSessionTaskDelegateSwizzler.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = URLSessionTaskDelegateSwizzler.swift; sourceTree = "<group>"; };
32203217
D2BEEDB42B33607D0065F3AC /* URLSessionSwizzler.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = URLSessionSwizzler.swift; sourceTree = "<group>"; };
32213218
D2BEEDB72B3360F50065F3AC /* URLSessionTaskDelegateSwizzlerTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = URLSessionTaskDelegateSwizzlerTests.swift; sourceTree = "<group>"; };
3219+
D2C179E02DD2388800556F68 /* SpanCoreContext.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SpanCoreContext.swift; sourceTree = "<group>"; };
32223220
D2C1A55A29C4F2DF00946C31 /* DatadogTrace.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = DatadogTrace.framework; sourceTree = BUILT_PRODUCTS_DIR; };
32233221
D2C1A57329C4F2E800946C31 /* DatadogTraceTests tvOS.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = "DatadogTraceTests tvOS.xctest"; sourceTree = BUILT_PRODUCTS_DIR; };
32243222
D2C5D52A2B84F6AB00B63F36 /* WebViewRecordReceiver.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = WebViewRecordReceiver.swift; sourceTree = "<group>"; };
@@ -4568,6 +4566,7 @@
45684566
61441C0324616DE9003D8BB8 /* Example */,
45694567
61133B83242393DE00786299 /* Products */,
45704568
61133C6F2423993200786299 /* Frameworks */,
4569+
D2C179DF2DD2383200556F68 /* Recovered References */,
45714570
);
45724571
sourceTree = "<group>";
45734572
};
@@ -6306,7 +6305,6 @@
63066305
616F1FAF283E227100651A3A /* LogsFeature.swift */,
63076306
D243BBF129A6209C000B9CEC /* RequestBuilder.swift */,
63086307
D243BBF429A620CC000B9CEC /* MessageReceivers.swift */,
6309-
D22C5BC52A989D130024CC1F /* Baggages.swift */,
63106308
);
63116309
path = Feature;
63126310
sourceTree = "<group>";
@@ -6335,7 +6333,6 @@
63356333
D2546C0329AF55AA0054E00B /* TraceFeature.swift */,
63366334
D2546C0729AF55E90054E00B /* RequestBuilder.swift */,
63376335
D2546C0A29AF56270054E00B /* MessageReceivers.swift */,
6338-
D22C5BCA2A98A5400024CC1F /* Baggages.swift */,
63396336
);
63406337
path = Feature;
63416338
sourceTree = "<group>";
@@ -6601,6 +6598,14 @@
66016598
path = SwiftUI;
66026599
sourceTree = "<group>";
66036600
};
6601+
D2C179DF2DD2383200556F68 /* Recovered References */ = {
6602+
isa = PBXGroup;
6603+
children = (
6604+
D24EC3D22DCE4720007A7E8F /* SpanCoreContext.swift */,
6605+
);
6606+
name = "Recovered References";
6607+
sourceTree = "<group>";
6608+
};
66046609
D2C5D5272B83FD3700B63F36 /* Models */ = {
66056610
isa = PBXGroup;
66066611
children = (
@@ -6629,6 +6634,7 @@
66296634
D2D748342DC223EE00C61353 /* Trace */ = {
66306635
isa = PBXGroup;
66316636
children = (
6637+
D2C179E02DD2388800556F68 /* SpanCoreContext.swift */,
66326638
D2D748382DC2306100C61353 /* TraceID.swift */,
66336639
D2D748392DC2306100C61353 /* SpanID.swift */,
66346640
);
@@ -8805,7 +8811,6 @@
88058811
615D52BB2C88A83A00F8B8FC /* SynchronizedTags.swift in Sources */,
88068812
D243BBF529A620CC000B9CEC /* MessageReceivers.swift in Sources */,
88078813
615D52B82C888C1F00F8B8FC /* SynchronizedAttributes.swift in Sources */,
8808-
D22C5BC92A98A0B30024CC1F /* Baggages.swift in Sources */,
88098814
);
88108815
runOnlyForDeploymentPostprocessing = 0;
88118816
};
@@ -8846,7 +8851,6 @@
88468851
615D52BC2C88A83A00F8B8FC /* SynchronizedTags.swift in Sources */,
88478852
D243BBF629A620CC000B9CEC /* MessageReceivers.swift in Sources */,
88488853
615D52B92C888C1F00F8B8FC /* SynchronizedAttributes.swift in Sources */,
8849-
D22C5BC82A98A0B20024CC1F /* Baggages.swift in Sources */,
88508854
);
88518855
runOnlyForDeploymentPostprocessing = 0;
88528856
};
@@ -8957,6 +8961,7 @@
89578961
D23039E5298D5236001A1FA3 /* DateProvider.swift in Sources */,
89588962
D23039E0298D5235001A1FA3 /* DatadogCoreProtocol.swift in Sources */,
89598963
D23039FD298D5236001A1FA3 /* DataCompression.swift in Sources */,
8964+
D2C179E12DD2388800556F68 /* SpanCoreContext.swift in Sources */,
89608965
B3E46CAE2D91B40000BABF66 /* NetworkContext.swift in Sources */,
89618966
D2EA0F462C0E1AE300CB20F8 /* SessionReplayConfiguration.swift in Sources */,
89628967
6167E6F92B81E95900C3CA2D /* BinaryImage.swift in Sources */,
@@ -9370,7 +9375,6 @@
93709375
D2C1A50B29C4C4CB00946C31 /* SpanEventBuilder.swift in Sources */,
93719376
D2C1A4FF29C4C4CB00946C31 /* Warnings.swift in Sources */,
93729377
D2C1A51729C4C53F00946C31 /* OTFormat.swift in Sources */,
9373-
D22C5BCB2A98A5400024CC1F /* Baggages.swift in Sources */,
93749378
3CFF5D492B555F4F00FC483A /* OTelTracerProvider.swift in Sources */,
93759379
D2C1A4FA29C4C4CB00946C31 /* SpanSanitizer.swift in Sources */,
93769380
D2C1A50A29C4C4CB00946C31 /* TraceFeature.swift in Sources */,
@@ -9629,7 +9633,6 @@
96299633
D2C1A54C29C4F2DF00946C31 /* SpanEventBuilder.swift in Sources */,
96309634
D2C1A54D29C4F2DF00946C31 /* Warnings.swift in Sources */,
96319635
D2C1A54E29C4F2DF00946C31 /* OTFormat.swift in Sources */,
9632-
D22C5BCC2A98A5400024CC1F /* Baggages.swift in Sources */,
96339636
3CFF5D4A2B555F4F00FC483A /* OTelTracerProvider.swift in Sources */,
96349637
D2C1A54F29C4F2DF00946C31 /* SpanSanitizer.swift in Sources */,
96359638
D2C1A55029C4F2DF00946C31 /* TraceFeature.swift in Sources */,
@@ -10037,6 +10040,7 @@
1003710040
D2DA237C298D57AA00C6C7E6 /* DatadogCoreProtocol.swift in Sources */,
1003810041
D2DA237D298D57AA00C6C7E6 /* DataCompression.swift in Sources */,
1003910042
D2C9A26A2C0F3F5A007526F5 /* SessionReplayConfiguration.swift in Sources */,
10043+
D2C179E22DD2388800556F68 /* SpanCoreContext.swift in Sources */,
1004010044
B3E46CAF2D91B40000BABF66 /* NetworkContext.swift in Sources */,
1004110045
6167E6FA2B81E95900C3CA2D /* BinaryImage.swift in Sources */,
1004210046
6174D60D2BFDDEDF00EC7469 /* SDKMetricFields.swift in Sources */,

‎DatadogInternal/Sources/Models/Trace/SpanCoreContext.swift

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
/*
2+
* Unless explicitly stated otherwise all files in this repository are licensed under the Apache License Version 2.0.
3+
* This product includes software developed at Datadog (https://www.datadoghq.com/).
4+
* Copyright 2019-Present Datadog, Inc.
5+
*/
6+
7+
import Foundation
8+
9+
/// The Trace context received from `Core`.
10+
public struct SpanCoreContext: AdditionalContext {
11+
public static let key = "span_context"
12+
13+
/// The Trace ID
14+
public let traceID: String
15+
/// The Span ID
16+
public let spanID: String
17+
18+
/// Creates a Span context.
19+
/// - Parameters:
20+
/// - traceID: The Trace ID
21+
/// - spanID: The Span ID
22+
public init(traceID: String, spanID: String) {
23+
self.traceID = traceID
24+
self.spanID = spanID
25+
}
26+
}

‎DatadogLogs/Sources/Feature/Baggages.swift

Lines changed: 0 additions & 21 deletions
This file was deleted.

‎DatadogLogs/Sources/RemoteLogger.swift

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -145,15 +145,9 @@ internal final class RemoteLogger: LoggerProtocol, Sendable {
145145
}
146146

147147
// When bundle with Trace is enabled, link RUM context (if available):
148-
if self.activeSpanIntegration, let spanContext = context.baggages[SpanContext.key] {
149-
do {
150-
let trace = try spanContext.decode(type: SpanContext.self)
151-
internalAttributes[LogEvent.Attributes.Trace.traceID] = trace.traceID?.toString(representation: .hexadecimal)
152-
internalAttributes[LogEvent.Attributes.Trace.spanID] = trace.spanID?.toString(representation: .decimal)
153-
} catch {
154-
self.featureScope.telemetry
155-
.error("Fails to decode Span context from Logs", error: error)
156-
}
148+
if self.activeSpanIntegration, let spanContext: SpanCoreContext = context.additionalContext() {
149+
internalAttributes[LogEvent.Attributes.Trace.traceID] = spanContext.traceID
150+
internalAttributes[LogEvent.Attributes.Trace.spanID] = spanContext.spanID
157151
}
158152

159153
// When binary images are requested, add them

‎DatadogLogs/Tests/RemoteLoggerTests.swift

Lines changed: 5 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -510,11 +510,11 @@ class RemoteLoggerTests: XCTestCase {
510510

511511
// When
512512
featureScope.contextMock = .mockWith(
513-
baggages: [
514-
"span_context": .init([
515-
"dd.trace_id": traceID.toString(representation: .hexadecimal),
516-
"dd.span_id": spanID.toString(representation: .decimal)
517-
])
513+
additionalContext: [
514+
SpanCoreContext(
515+
traceID: traceID.toString(representation: .hexadecimal),
516+
spanID: spanID.toString(representation: .decimal)
517+
)
518518
]
519519
)
520520
logger.info("message")
@@ -552,36 +552,4 @@ class RemoteLoggerTests: XCTestCase {
552552
XCTAssertNil(log.attributes.internalAttributes?["dd.span_id"])
553553
XCTAssertTrue(featureScope.telemetryMock.messages.isEmpty)
554554
}
555-
556-
func testWhenActiveSpanIntegrationIsEnabled_withMalformedRUMContext_itSendsTelemetryError() throws {
557-
// Given
558-
let logger = RemoteLogger(
559-
featureScope: featureScope,
560-
globalAttributes: .mockAny(),
561-
configuration: .mockAny(),
562-
dateProvider: RelativeDateProvider(),
563-
rumContextIntegration: false,
564-
activeSpanIntegration: true,
565-
backtraceReporter: BacktraceReporterMock()
566-
)
567-
568-
// When
569-
featureScope.contextMock = .mockWith(
570-
baggages: [
571-
"span_context": .init("malformed Span context")
572-
]
573-
)
574-
logger.info("message")
575-
576-
// Then
577-
let logs = featureScope.eventsWritten(ofType: LogEvent.self)
578-
XCTAssertEqual(logs.count, 1)
579-
580-
let log = try XCTUnwrap(logs.first)
581-
XCTAssertNil(log.attributes.internalAttributes?["dd.trace_id"])
582-
XCTAssertNil(log.attributes.internalAttributes?["dd.span_id"])
583-
584-
let error = try XCTUnwrap(featureScope.telemetryMock.messages.firstError())
585-
XCTAssert(error.message.contains("Fails to decode Span context from Logs - typeMismatch"))
586-
}
587555
}

‎DatadogTrace/Sources/DatadogTracer.swift

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -169,13 +169,12 @@ internal final class DatadogTracer: OTTracer, OpenTelemetryApi.Tracer {
169169
let context = activeSpan?.context as? DDSpanContext
170170

171171
featureScope.set(
172-
baggage: context.map {
172+
context: context.map {
173173
SpanCoreContext(
174174
traceID: String($0.traceID, representation: .hexadecimal),
175175
spanID: String($0.spanID, representation: .decimal)
176176
)
177-
},
178-
forKey: SpanCoreContext.key
177+
}
179178
)
180179
}
181180
// MARK: - OpenTelemetry

‎DatadogTrace/Sources/Feature/Baggages.swift

Lines changed: 0 additions & 19 deletions
This file was deleted.

0 commit comments

Comments
 (0)