Skip to content

Commit c0e3384

Browse files
authored
Merge pull request #10 from DbUp/xml-doc
Add XML documentation for all public members
2 parents 6e8c52d + 24f7d2e commit c0e3384

File tree

5 files changed

+19
-10
lines changed

5 files changed

+19
-10
lines changed

src/dbup-firebird/FirebirdConnectionManager.cs

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
using System.Collections.Generic;
1+
using System.Collections.Generic;
22
using System.Linq;
33
using System.Text.RegularExpressions;
44
using DbUp.Engine.Transactions;
@@ -19,10 +19,7 @@ public class FirebirdConnectionManager : DatabaseConnectionManager
1919
{
2020
}
2121

22-
/// <summary>
23-
/// Splits the statements in the script using the ";" character.
24-
/// </summary>
25-
/// <param name="scriptContents">The contents of the script to split.</param>
22+
/// <inheritdoc/>
2623
public override IEnumerable<string> SplitScriptIntoCommands(string scriptContents)
2724
{
2825
// TODO: Possible Change - this is the PostGres version
@@ -35,6 +32,7 @@ public override IEnumerable<string> SplitScriptIntoCommands(string scriptContent
3532
return scriptStatements;
3633
}
3734

35+
/// <inheritdoc/>
3836
protected override AllowedTransactionMode AllowedTransactionModes => AllowedTransactionMode.TransactionPerScript;
3937
}
4038
}

src/dbup-firebird/FirebirdObjectParser.cs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
using DbUp.Support;
1+
using DbUp.Support;
22

33
namespace DbUp.Firebird
44
{
@@ -7,6 +7,9 @@ namespace DbUp.Firebird
77
/// </summary>
88
public class FirebirdObjectParser : SqlObjectParser
99
{
10+
/// <summary>
11+
/// Initializes a new instance of the <see cref="FirebirdObjectParser"/> class.
12+
/// </summary>
1013
public FirebirdObjectParser() : base("\"", "\"")
1114
{
1215
}

src/dbup-firebird/FirebirdScriptExecutor.cs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
using System;
1+
using System;
22
using System.Collections.Generic;
33
using DbUp.Engine;
44
using DbUp.Engine.Output;
@@ -21,13 +21,14 @@ public class FirebirdScriptExecutor : ScriptExecutor
2121
/// <param name="schema">The schema that contains the table.</param>
2222
/// <param name="variablesEnabled">Function that returns <c>true</c> if variables should be replaced, <c>false</c> otherwise.</param>
2323
/// <param name="scriptPreprocessors">Script Preprocessors in addition to variable substitution</param>
24-
/// <param name="journalFactory">Database journal</param>
24+
/// <param name="journal">Database journal</param>
2525
public FirebirdScriptExecutor(Func<IConnectionManager> connectionManagerFactory, Func<IUpgradeLog> log, string schema, Func<bool> variablesEnabled,
2626
IEnumerable<IScriptPreprocessor> scriptPreprocessors, Func<IJournal> journal)
2727
: base(connectionManagerFactory, new FirebirdObjectParser(), log, schema, variablesEnabled, scriptPreprocessors, journal)
2828
{
2929
}
3030

31+
/// <inheritdoc/>
3132
protected override string GetVerifySchemaSql(string schema)
3233
{
3334
throw new NotSupportedException();
@@ -39,6 +40,7 @@ protected override string GetVerifySchemaSql(string schema)
3940
/// </summary>
4041
protected override bool UseTheSameTransactionForJournalTableAndScripts => false;
4142

43+
/// <inheritdoc/>
4244
protected override void ExecuteCommandsWithinExceptionHandler(int index, SqlScript script, Action executeCommand)
4345
{
4446
try

src/dbup-firebird/FirebirdTableJournal.cs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
using System;
1+
using System;
22
using System.Data;
33
using DbUp.Engine;
44
using DbUp.Engine.Output;
@@ -51,6 +51,7 @@ void ExecuteCommand(Func<IDbCommand> dbCommandFactory, string sql)
5151
}
5252
}
5353

54+
/// <inheritdoc/>
5455
protected override void OnTableCreated(Func<IDbCommand> dbCommandFactory)
5556
{
5657
var unquotedTableName = UnquoteSqlObjectName(FqSchemaTableName);
@@ -60,21 +61,25 @@ protected override void OnTableCreated(Func<IDbCommand> dbCommandFactory)
6061
Log().LogInformation($"The {TriggerName(unquotedTableName)} trigger has been created");
6162
}
6263

64+
/// <inheritdoc/>
6365
protected override string DoesTableExistSql()
6466
{
6567
return $"select 1 from RDB$RELATIONS where RDB$SYSTEM_FLAG = 0 and RDB$RELATION_NAME = '{UnquotedSchemaTableName}'";
6668
}
6769

70+
/// <inheritdoc/>
6871
protected override string GetInsertJournalEntrySql(string @scriptName, string @applied)
6972
{
7073
return $"insert into {FqSchemaTableName} (ScriptName, Applied) values ({scriptName}, {applied})";
7174
}
7275

76+
/// <inheritdoc/>
7377
protected override string GetJournalEntriesSql()
7478
{
7579
return $"select ScriptName from {FqSchemaTableName} order by ScriptName";
7680
}
7781

82+
/// <inheritdoc/>
7883
protected override string CreateSchemaTableSql(string quotedPrimaryKeyName)
7984
{
8085
return

src/dbup-firebird/dbup-firebird.csproj

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<Project Sdk="Microsoft.NET.Sdk">
1+
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
44
<Description>DbUp makes it easy to deploy and upgrade SQL Server databases. This package adds Firebird support.</Description>
@@ -15,6 +15,7 @@
1515
<RepositoryUrl>https://github.com/DbUp/dbup-firebird.git</RepositoryUrl>
1616
<PackageIcon>dbup-icon.png</PackageIcon>
1717
<PublicSign Condition=" '$(OS)' != 'Windows_NT' ">true</PublicSign>
18+
<GenerateDocumentationFile>true</GenerateDocumentationFile>
1819
</PropertyGroup>
1920

2021
<PropertyGroup Condition="'$(CI)' == 'true'">

0 commit comments

Comments
 (0)