improve codestyle

Author: DeOldSax

src/main/java/analytics/AnalyticsLogger.java

@@ -14,6 +14,8 @@
 
 public class AnalyticsLogger {
 
+    public static String url = "https://www.iliasdownloadertool.de/api/v1/analytics";
+
     public static AnalyticsLogger logger;
 
     private final String sessionID;
@@ -24,7 +26,7 @@ public class AnalyticsLogger {
 
     private final String iliasPortal;
 
-    public AnalyticsLogger() {
+    private AnalyticsLogger() {
         this.sessionID = generateSessionID();
         this.iliasVersion = new VersionValidator().getVersion();
         this.userID = generateUserID();
@@ -40,9 +42,9 @@ public static AnalyticsLogger getInstance() {
 
     private String generateUserID() {
         String name = Settings.getInstance().getUser().getName();
-        String shortName = IliasManager.getInstance().getShortName();
+        String pluginShortName = IliasManager.getInstance().getShortName();
 
-        return hash(hash(name) + hash(shortName) + hash("G(xpt+OgoLltz5b#e(Bu-YcYF$cokfmp9349fdjd!-4sdvf2"));
+        return hash(hash(name) + hash(pluginShortName) + hash("G(xpt+OgoLltz5b#e(Bu-YcYF$cokfmp9349fdjd!-4sdvf2"));
     }
 
     private String generateSessionID() {
@@ -52,14 +54,13 @@ private String generateSessionID() {
     public void log(Enum actionType) {
         new Thread(() -> {
             CloseableHttpClient client = HttpClients.createDefault();
-            String uri = "http://localhost:5000/api/v1/analytics";
-            String uri2 = "https://www.iliasdownloadertool.de/api/v1/analytics";
-            HttpPost httpPost = new HttpPost(uri2);
+
+            HttpPost httpPost = new HttpPost(url);
 
             SessionLog sessionLog = new SessionLog(this.userID, this.sessionID, actionType,
                     this.iliasVersion, this.iliasPortal);
 
-            StringEntity entity = null;
+            StringEntity entity;
             try {
                 entity = new StringEntity(sessionLog.toJson());
                 httpPost.setEntity(entity);

src/main/java/download/IliasFileDownloader.java

@@ -68,18 +68,15 @@ private void askForStoragePosition(String name, final String targetPath, final I
 		fileChooser.setInitialDirectory(new File(targetPath));
 		fileChooser.setInitialFileName(name + "." + file.getExtension());
 
-		Platform.runLater(new Runnable() {
-			@Override
-			public void run() {
-				final File selectedFile = fileChooser.showSaveDialog(new Stage());
-				String path = targetPath;
-				if (selectedFile != null) {
-					path = selectedFile.getAbsolutePath();
-					if (!path.endsWith("." + file.getExtension())) {
-						path = path + "." + file.getExtension();
-					}
-					new Thread(new IliasFileDownloaderTask(file, path)).start();
+		Platform.runLater(() -> {
+			final File selectedFile = fileChooser.showSaveDialog(new Stage());
+			String path = targetPath;
+			if (selectedFile != null) {
+				path = selectedFile.getAbsolutePath();
+				if (!path.endsWith("." + file.getExtension())) {
+					path = path + "." + file.getExtension();
 				}
+				new Thread(new IliasFileDownloaderTask(file, path)).start();
 			}
 		});
 	}

src/main/java/utils/FileAppearanceManager.java

@@ -26,10 +26,10 @@ public class FileAppearanceManager {
 	private Map<String, String> ignoredPictures; 
 
 	private FileAppearanceManager() {
-		fileExtensions = new ArrayList<String>(); 
-		normalPictures = new HashMap<String, String>(); 
-		notSynchronizedPictures = new HashMap<String, String>(); 
-		ignoredPictures = new HashMap<String, String>(); 
+		fileExtensions = new ArrayList<>();
+		normalPictures = new HashMap<>();
+		notSynchronizedPictures = new HashMap<>();
+		ignoredPictures = new HashMap<>();
 
 		try {
 			readPropertyFile();