Skip to content

Commit cc3142d

Browse files
Pull default TTL value into a constant
Co-authored-by: jonathannorris <[email protected]>
1 parent d9a43fa commit cc3142d

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

DevCycle/Models/DevCycleOptions.swift

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,16 @@
55

66
import Foundation
77

8+
// Default TTL for config cache (30 days in milliseconds)
9+
internal let DEFAULT_CONFIG_CACHE_TTL: Int = 2_592_000_000
10+
811
public class DevCycleOptions {
912
private(set) public var eventFlushIntervalMS: Int?
1013
private(set) public var disableEventLogging: Bool?
1114
public var logLevel: LogLevel = .error
1215
private(set) public var enableEdgeDB: Bool = false
1316
private(set) public var disableConfigCache: Bool = false
14-
private(set) public var configCacheTTL: Int = 2_592_000_000
17+
private(set) public var configCacheTTL: Int = DEFAULT_CONFIG_CACHE_TTL
1518
private(set) public var disableRealtimeUpdates: Bool = false
1619
private(set) public var disableAutomaticEventLogging: Bool = false
1720
private(set) public var disableCustomEventLogging: Bool = false
@@ -76,7 +79,7 @@ public class DevCycleOptions {
7679
}
7780

7881
// The maximum allowed age of a cached config in milliseconds, defaults to 30 days
79-
public func configCacheTTL(_ ttl: Int = 2_592_000_000) -> OptionsBuilder {
82+
public func configCacheTTL(_ ttl: Int = DEFAULT_CONFIG_CACHE_TTL) -> OptionsBuilder {
8083
self.options.configCacheTTL = ttl
8184
return self
8285
}

DevCycleTests/Models/DevCycleOptionsTest.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,8 @@ class DevCycleOptionsTest: XCTestCase {
6464

6565
func testDefaultConfigCacheTTL() {
6666
let options = DevCycleOptions()
67-
// Default TTL should be 30 days (2,592,000,000 milliseconds)
68-
XCTAssertEqual(options.configCacheTTL, 2_592_000_000, "Default config cache TTL should be 30 days")
67+
// Default TTL should be 30 days
68+
XCTAssertEqual(options.configCacheTTL, DEFAULT_CONFIG_CACHE_TTL, "Default config cache TTL should be 30 days")
6969
}
7070

7171
func testConfigCacheTTLCustomization() {

0 commit comments

Comments
 (0)