Skip to content

Commit 280b11a

Browse files
authored
Apply suggestions from code review
1 parent 6cae4cf commit 280b11a

File tree

2 files changed

+8
-10
lines changed

2 files changed

+8
-10
lines changed

StyleCop.Analyzers/StyleCop.Analyzers.Test.CSharp9/OrderingRules/SA1212CSharp9UnitTests.cs

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ namespace StyleCop.Analyzers.Test.CSharp9.OrderingRules
55
{
66
using System.Threading;
77
using System.Threading.Tasks;
8+
using Microsoft.CodeAnalysis.Testing;
89
using StyleCop.Analyzers.Test.CSharp8.OrderingRules;
9-
using StyleCop.Analyzers.Test.Verifiers;
1010
using Xunit;
1111
using static StyleCop.Analyzers.Test.Verifiers.StyleCopCodeFixVerifier<
1212
StyleCop.Analyzers.OrderingRules.SA1212PropertyAccessorsMustFollowOrder,
@@ -30,13 +30,12 @@ public class Foo
3030
public int Prop { get; init; }
3131
}";
3232

33-
var test = new CSharpTest
33+
await new CSharpTest
3434
{
3535
TestCode = testCode,
3636
FixedCode = fixedCode,
37-
ReferenceAssemblies = GenericAnalyzerTest.ReferenceAssembliesNet50,
38-
};
39-
await test.RunAsync(CancellationToken.None).ConfigureAwait(false);
37+
ReferenceAssemblies = ReferenceAssemblies.Net.Net50,
38+
}.RunAsync(CancellationToken.None).ConfigureAwait(false);
4039
}
4140

4241
[Fact]
@@ -81,13 +80,12 @@ public int Prop
8180
}
8281
}";
8382

84-
var test = new CSharpTest
83+
await new CSharpTest
8584
{
8685
TestCode = testCode,
8786
FixedCode = fixedCode,
88-
ReferenceAssemblies = GenericAnalyzerTest.ReferenceAssembliesNet50,
89-
};
90-
await test.RunAsync(CancellationToken.None).ConfigureAwait(false);
87+
ReferenceAssemblies = ReferenceAssemblies.Net.Net50,
88+
}.RunAsync(CancellationToken.None).ConfigureAwait(false);
9189
}
9290
}
9391
}

StyleCop.Analyzers/StyleCop.Analyzers/OrderingRules/SA1212PropertyAccessorsMustFollowOrder.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ private static void AnalyzeProperty(SyntaxNodeAnalysisContext context, BasePrope
100100
return;
101101
}
102102

103-
if ((accessors[0].Kind() == SyntaxKind.SetAccessorDeclaration || accessors[0].Kind() == SyntaxKindEx.InitAccessorDeclaration) &&
103+
if ((accessors[0].Kind() is SyntaxKind.SetAccessorDeclaration or SyntaxKindEx.InitAccessorDeclaration) &&
104104
accessors[1].Kind() == SyntaxKind.GetAccessorDeclaration)
105105
{
106106
context.ReportDiagnostic(Diagnostic.Create(Descriptor, accessors[0].GetLocation()));

0 commit comments

Comments
 (0)