Skip to content

Conversation

@xdje42
Copy link
Contributor

@xdje42 xdje42 commented Jan 31, 2024

And remove reference to Jenkins since, while used, is done as part of a Github Action, and thus there's no separate place to look for failures.

And remove reference to Jenkins since, while used, is done as part of
a Github Action, and thus there's no separate place to look for failures.
@xdje42 xdje42 requested a review from derekbruening January 31, 2024 23:30
/**
****************************************************************************
\page page_triager Triager Rotation

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And remove reference to Jenkins since, while used, is done as part of a Github Action, and thus there's no separate place to look for failures.

nit: Generally the body should stand on its own, including repeating what is in the title if necessary: i.e., best to not start it with "And". The title is not always right there depending on what history tool is used.

- Do this by going to the Github Actions page: https://github.com/DynamoRIO/dynamorio/actions.
- If flaky tests are failing too often, assign someone to fix them ASAP, or mark them to be ignored in `runsuite_wrapper.pl`.
- Watch merges to master for failures on the longer test suite.
- Do this by watching for merges on the dynamorio-devs@ list.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to look at the devs list. These are on the same Actions page linked above, to find details -- but the summary page is the green check or red X by each commit at https://github.com/DynamoRIO/dynamorio/commits/master/ . That's what the goal is: to have that page contain nothing but green checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants