Skip to content

Conversation

@DmitrySPetrov
Copy link
Contributor

@DmitrySPetrov DmitrySPetrov commented Sep 5, 2025

  • Implemented support for nested maps like
    name0 { name1 { name2 val2 } }

  • Removed unnecessary class attributes

  • Implemented template function get_type_name which returns
    human-readable type name. This function would be used for
    error reporting.

@DmitrySPetrov DmitrySPetrov force-pushed the i7590-config-reader-refactoring branch from be29001 to 4dbedd9 Compare September 5, 2025 23:15
@abhinav92003
Copy link
Contributor

When this is ready for review, please add me to the reviewers.

@derekbruening
Copy link
Contributor

Is this part of adding new features or is it cleanup only? If it is cleanup to prepare for adding a new feature it would be good to file an issue on the feature and link here to help indicate the end goal. I thought we already had one filed on improving these config files to avoid having to duplicate entries: some kind of repeated entry automation. But I can't find it so we must have just talked about it and not filed it.

@DmitrySPetrov
Copy link
Contributor Author

When this is ready for review, please add me to the reviewers.

OK, Sure, I'll do it! Thanks!

@DmitrySPetrov
Copy link
Contributor Author

Is this part of adding new features or is it cleanup only? If it is cleanup to prepare for adding a new feature it would be good to file an issue on the feature and link here to help indicate the end goal. I thought we already had one filed on improving these config files to avoid having to duplicate entries: some kind of repeated entry automation. But I can't find it so we must have just talked about it and not filed it.

This part is code refactoring & cleanup. After this one I'll create one more PR to support cache replacement policy configuration.
If it's necessary to create new issue, please let me know.

@DmitrySPetrov DmitrySPetrov force-pushed the i7590-config-reader-refactoring branch 2 times, most recently from d138fad to a5328c1 Compare September 21, 2025 20:53
@DmitrySPetrov DmitrySPetrov force-pushed the i7590-config-reader-refactoring branch 2 times, most recently from dd2cede to 122b55f Compare October 15, 2025 21:22
- Implemented support for nested maps like
    name0 { name1 { name2 val2 } }
- Moved private class methods into unnamed namespace
- Removed unnecessary class attributes

- Implemented template function `get_type_name` which returns
  human-readable type name. This function would be used for
  error reporting.

- Implemented unit tests for configuration reader

Issue: DynamoRIO#7590
- Implemented tokeniser class skeleton
- Refactored stream reading functionality
@DmitrySPetrov DmitrySPetrov force-pushed the i7590-config-reader-refactoring branch 2 times, most recently from 64aeb9e to c4fd783 Compare November 5, 2025 19:57
@DmitrySPetrov DmitrySPetrov force-pushed the i7590-config-reader-refactoring branch from c4fd783 to 0720da9 Compare November 5, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants