-
Notifications
You must be signed in to change notification settings - Fork 603
i#7590: Drcachesim configuration reader refactoring #7619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
i#7590: Drcachesim configuration reader refactoring #7619
Conversation
be29001 to
4dbedd9
Compare
|
When this is ready for review, please add me to the reviewers. |
|
Is this part of adding new features or is it cleanup only? If it is cleanup to prepare for adding a new feature it would be good to file an issue on the feature and link here to help indicate the end goal. I thought we already had one filed on improving these config files to avoid having to duplicate entries: some kind of repeated entry automation. But I can't find it so we must have just talked about it and not filed it. |
OK, Sure, I'll do it! Thanks! |
This part is code refactoring & cleanup. After this one I'll create one more PR to support cache replacement policy configuration. |
d138fad to
a5328c1
Compare
dd2cede to
122b55f
Compare
- Implemented support for nested maps like
name0 { name1 { name2 val2 } }
- Moved private class methods into unnamed namespace
- Removed unnecessary class attributes
- Implemented template function `get_type_name` which returns
human-readable type name. This function would be used for
error reporting.
- Implemented unit tests for configuration reader
Issue: DynamoRIO#7590
- Implemented tokeniser class skeleton - Refactored stream reading functionality
64aeb9e to
c4fd783
Compare
c4fd783 to
0720da9
Compare
Implemented support for nested maps like
name0 { name1 { name2 val2 } }
Removed unnecessary class attributes
Implemented template function
get_type_namewhich returnshuman-readable type name. This function would be used for
error reporting.